openstack/heat
Code Issues Proposed changes

FunctionalTests don't run non-test check_skip_test

Browse Source 
This is actually a helper function which is called from the base-class
setUp methods, but we're running it like a test because the test
runner sees "test" in the name.

Change-Id: I9d350471a3f3f40a201294adebd7752e3a7aa020
This commit is contained in:
Steven Hardy 2016-01-18 17:23:20 +00:00
parent 336f0f8f34
commit a6e4fc7fae
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
heat_integrationtests/functional/functional_base.py
View File

@ -17,10 +17,10 @@ class FunctionalTestsBase(test.HeatIntegrationTest):
def setUp(self):
super(FunctionalTestsBase, self).setUp()
self.check_skip_test()
self.check_skip()
self.client = self.orchestration_client
def check_skip_test(self):
def check_skip(self):
test_cls_name = self.__class__.__name__
test_method_name = '.'.join([test_cls_name, self._testMethodName])
test_skipped = (self.conf.skip_functional_test_list and (

4
heat_integrationtests/scenario/scenario_base.py
View File

@ -18,7 +18,7 @@ class ScenarioTestsBase(test.HeatIntegrationTest):
def setUp(self):
super(ScenarioTestsBase, self).setUp()
self.check_skip_test()
self.check_skip()
self.client = self.orchestration_client
self.sub_dir = 'templates'
@ -58,7 +58,7 @@ class ScenarioTestsBase(test.HeatIntegrationTest):
return stack_id
def check_skip_test(self):
def check_skip(self):
test_cls_name = self.__class__.__name__
test_method_name = '.'.join([test_cls_name, self._testMethodName])
test_skipped = (self.conf.skip_scenario_test_list and (