236 Commits

Author SHA1 Message Date
Zane Bitter
9029db524f Dashboard creator: fix bugs query
Gerrit used to allow regexps in topic: queries, but now topic: is only
for exact matches. intopic: can be used to search within topics.

Change-Id: Icc5c80ead124b4383198915984543a7987b1bf2e
2018-03-26 17:07:15 -04:00
Zuul
8dc51eac14 Merge "Add Heat review dashboard config files" 2018-02-11 08:45:46 +00:00
ricolin
ffeaf1b8ce Add Heat review dashboard config files
Add main review dashboard config file, and doc for how to generate it.

Change-Id: I47860f9840dfa84041709e38ac361f8756171eb7
2018-02-07 17:12:06 +08:00
Zane Bitter
22da551c8c Use correct raw string format
You're not supposed to just randomly put backslashes in front of other
characters that don't need escaping unless it's a raw string. This is
deprecated in Python 3.6.

Change-Id: I7a69ba6dd10412bb065f2b6ba405840d0a98663a
2017-11-16 18:23:58 -05:00
Ihar Hrachyshka
3ae6afa449 Remove subunit-trace fork
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, like the one making the gate fail
if for some reason no tests are executed because all of them are
skipped.

Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
2017-04-06 11:42:05 -07:00
Jenkins
dbd92e29b3 Merge "Check all resources with custom guidelines" 2017-04-03 10:01:07 +00:00
liyi
8f10215ffd Remove log translations
Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

Change-Id: Ieec8028305099422e1b0f8fc84bc90c9ca6c694f
2017-03-25 17:11:50 +08:00
Peter Razumovsky
8d6d1ac935 Check all resources with custom guidelines
If resource has available_resource_mapping method and
it's not available, custom guidelines check will skip it,
which is incorrect. This patch improves list of resources:
now only hidden, contrib and manually excluded resources
don't checked.

Change-Id: Ic2cb37fb3fe4aefb8b3efb911aecf46155541469
Closes-bug: #1674949
2017-03-22 14:24:18 +04:00
Andreas Jaeger
6e5593f11b Prepare for using standard python tests
Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.

This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.

See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html

Update HACKING for this.

Needed-By: I98c1b799e520cad102b9e47cf51477f54b07e732
Change-Id: Id5e3b67190866acdebee2b89f4393d5c407a5b96
2017-02-04 09:49:18 +01:00
Ha Van Tu
ffdf485c43 Fix typo
This patch fixes typo "proccesed" in the code.

Change-Id: I79169c7742d50bb9504aba39879eae17879a4663
2016-11-28 18:32:22 +07:00
Peter Razumovsky
0ff37ff859 Don't raise error in custom guidelines on IOError
In some merge issues files or modules can be removed, but
still registered in global env. In that cases custom guidelines
raises an error with the message "No such file or directory".
Add exception handling to avoid error raising. Instead of error,
call warning and skip such class.

Change-Id: I71af2fffc2bdec414cb68c40eaf3268fe81134de
Closes-bug: #1613669
2016-08-24 09:36:02 +00:00
Zane Bitter
4200c6ccc0 Refactor confusing code in custom_guidelines.py
Change-Id: Iae7efbb8fe4157301deebd0776139489832f470f
2016-05-09 11:38:56 -04:00
Steve Baker
6e2d1a459a Exclude plugins from custom_guidelines.py
This is broken by our plugin package magic, so lets exclude
the plugin package from this tool.

Change-Id: I2da474b706cdb33e98675edabb0f607106c816d0
2016-05-09 08:57:24 +12:00
Sergey Kraynev
af0903a916 Ignore template res types during guideline checks
Global environment during registering resources also load resources from
/etc/environment.d . As result it loads two resources mapped on
templates:
- 'AWS::CloudWatch::Alarm'
- 'AWS::RDS::DBInstance'

However execute guideline checks for these resources is not possible due
to these resources use template_resource object and can not be processed
as usual *.py file.

This patch add ignoring for these two resource types.
Note: this error is not displayed on pep8 gate job due to we don't
install devstack during execution this job, but this error affects all
environments with installed devstack.

Closes-Bug: #1552194

Change-Id: I29abdfa1a4f4a17dfbcdaaf6f0c6665359bab17a
2016-03-02 08:25:58 -05:00
Peter Razumovsky
a5338c90c3 Fix all trailing spaces for custom guidelines
There are several trailing spaces error raised by
custom guidelines check. Need to fix them for successful
pep8 running.

implements bp custom-guidelines

Change-Id: Ibf50208155315e75795d7b9c8a8dbe487f9046ac
2016-02-26 15:50:31 +03:00
Peter Razumovsky
753f4c65e2 Fix all method errors for custom guidelines
There are several method error raised during custom
guidelines check. Need to fix it for successful running
pep8.

implements bp custom-guidelines

Change-Id: I55883bb8d314f982161aaa21c010e9d1467bf903
2016-02-26 15:50:29 +03:00
Peter Razumovsky
e4dc942ce1 Fix resources descriptions for custom guidelines
There're several errors, raised by custom guidelines check,
need to fix it for successful pep8 running.

implements bp custom-guidelines

Change-Id: Ibef41cad9b20715a740cedac7b98e9647bd3d6b7
2016-02-26 15:47:46 +03:00
Peter Razumovsky
2da713fa91 Fix all attributes error for custom guidelines
There are several errors during attributes descriptions
checking by custom guidelines. Need to fix them for
successful pep8 running.

implements bp custom-guidelines

Change-Id: I3df75c6343217723fd4490f9e70eb2d8499eb5ae
2016-02-26 15:47:46 +03:00
Peter Razumovsky
1d16909dfd Fix all properties errors for custom guidelines
There are several errors, raised during properties schemas
checking by custom guidelines. Need to fix them for successful
pep8 running.

implements bp custom-guidelines

Change-Id: Icd24498b8d36106412a61d4b82b00eb92095ffe9
2016-02-26 15:47:46 +03:00
Peter Razumovsky
874a9ba7da Implement custom guidelines
Implement custom guidelines for next cases:

 * resources descriptions
 * properties schemas descriptions
 * attributes schemas descriptions
 * methods descriptions
 * trailing spaces in attributes and properties
   descriptions

Also, enable custom guidelines check in pep8 checking.

implements bp custom-guidelines

Change-Id: Ic7b1061abfb42880c476602edb45bc40da291eb0
2016-02-19 18:37:59 +03:00
Sirushti Murugesan
a61de3c126 py34: cleanup
* Tests were skipped due to a mox3 bug. The bug has now been fixed
  and there's a new release of mox3. Unskip it.
* Remove the tool run-py3-tests.sh which isn't needed anymore.

blueprint heat-python34-support

Change-Id: I304d87e4313148c10a2465bf92ae932f525bb4ce
2015-10-08 20:10:54 +05:30
Sirushti Murugesan
7a7820c4ff Add a way to run py34 tests from file
Also, fix minor flake8 issue related to Long literal.

This should now have the python34 gate job passing.

partial blueprint heat-python34-support

Change-Id: I7f85e7251fc96587df0b43daac202c38542a6f6c
2015-07-09 07:15:37 +00:00
Shilla Saebi
47ea20b8ea changed heat dev docs to comply with conventions
With the incorporation of many projects within OpenStack, it's very important to
use standards in the documentation This is important for formalization as well
as consistency
the proper usage is: heat or Orchestration or Orchestration module
heat should not be capitalized
https://wiki.openstack.org/wiki/Documentation/Conventions

Change-Id: Ia8d7f1429f877e4c88fc9b210948b63443376ba0
2015-04-24 22:03:07 -04:00
Pavlo Shchelokovskyy
edfa76b3d5 Add lists of Linux dependencies
As a help for new developers add lists of RPM/DEB packages to install
on a clean new system in order to successfully run
Heat's unit test suit locally.

Also, update tools/README

Change-Id: Ibed2b7b9d9eef34d88ce667c82020a1980d98646
2015-01-23 16:02:53 +00:00
Thomas Herve
ec6ff6f670 Use oslo.config generator
Replace usage of old incubator configuration generator by the
oslo.config tool.

tools/config/generate_sample.sh has been replaced by tox -egenconfig.

heat_integrationtests/generate_sample.sh has been replaced by
oslo-config-generator
--config-file=heat_integrationtests/config-generator.conf

Change-Id: I6d95df203b556c8ec2088d40a446427f7087b9a7
2015-01-02 13:14:20 +01:00
Tetiana Lashchova
475f61fc9f Bring over pretty_tox.sh from nova
- added full log for integration tests by default
- added env 'py27log' which allows to get log for unit-tests

Change-Id: I43ca330c82ffe100247102021fce1f00acb4d11a
2014-12-25 18:00:32 +02:00
Pavlo Shchelokovskyy
8516d12d60 Remove run_tests.sh
This tool is deprecated in favor of tox for a long time already.
Moreover, currently it is broken as it tries to run
our in-tree integration tests as well.

So instead of fixing it, just finally remove it.

Change-Id: Icb3c4d423031456b8b24a84e97e310df077d9990
2014-12-10 19:10:27 +02:00
Steven Hardy
99768809f4 Remove config check_uptodate test
Our gate is currently broken due to an oslo library release,
so remove this check while we move to removing the sample config
(which requires changes to devstack to use tox -egenconfig)

Change-Id: Id4a37e9a5be156fea05c96e385c23da016ea9e69
2014-12-03 20:34:09 +00:00
Steven Hardy
2df03f6849 Remove oslo sslutils
This module isn't referenced in openstack-common.conf and is unused
so remove it

Change-Id: I602f40c511095818a8aee5f342029993bd470de4
Partial-Bug: #1380629
2014-10-27 09:21:18 +00:00
Brant Knudson
91ca44fe36 Update references to auth_token middleware
There's references to the auth_token middleware in keystoncelient.
The auth_token middleware has been moved to keystonemiddleware and
the version in keystoneclient shouldn't be used anymore.

If these references aren't updated, then when options are changed in
keystonemiddleware.auth_token the heat-api will fail to start because
there's duplicate options in keystoneclient.middleware.auth_token.

Change-Id: I04573aa5ff967afe3e00329f797fcc71b779e7b3
Closes-Bug: #1379082
2014-10-09 15:46:30 -05:00
Andreas Jaeger
3ebd84bf3c warn against sorting requirements
And do not check for sorted files.

Change-Id: I64ae9191863564e278a35d42ec9cd743a233028e
Closes-Bug: 1365061
2014-09-03 22:28:34 +02:00
Jenkins
2bdc11bf68 Merge "Remove rst2script.sed and integration.sh" 2014-07-28 15:19:20 +00:00
Ryan Brown
6eab982dad Remove rst2script.sed and integration.sh
rst2script.sed was referenced in the Fedora getting started
documentation, but the recommended way to use Heat/Openstack
on Fedora is now to use RDO/packstack.

Also removes the reference to rst2script.sed in the
getting_started/on_fedora documentation.

Also removes obsolete integration.sh script.

Partial-Bug: 1338066

Change-Id: I7f2b0d84ccef324ccb8e32ca4c6d90f9a3f2dda3
2014-07-25 12:40:36 -04:00
Ryan Brown
85aa4fcc5a Remove deprecated tools/README instructions
Remove instructions for:

experimental_ssh_eventlet.py: deleted May 25, 2014 commit 318669f

openstack: deleted Sep 30, 2013 commit f4a9c0f

heat-keystone-setup: was never in the tools directory, but has
documentation in the man pages

Change-Id: I8ae3050e16163699849342e81d302942e763ac0c
Partial-Bug: 1338066
2014-07-24 16:12:29 -04:00
Jenkins
50ab034b0a Merge "Remove tools/glance-jeos-add-from-github.sh" 2014-07-24 11:37:46 +00:00
Jenkins
0d1b5830bd Merge "Migrate to oslo.db" 2014-07-24 09:54:39 +00:00
Ryan Brown
a8899b0dbb Remove tools/glance-jeos-add-from-github.sh
glance-jeos-add-from-github.sh has not been edited since 2012-08-20, and
its image links have been broken (according to Google cache) for a
minimum of 9 months.

The functionality of the script seems to be superceded by the
handy-dandy diskimage-builder tool.

See http://docs.openstack.org/developer/heat/getting_started/jeos_building.html
for more info about diskimage-builder workflow.

Change-Id: I99880f1cca4af84fa7193d749a7c8f6957bb0b78
Partial-Bug: 1338066
2014-07-18 12:20:05 -04:00
Ryan Brown
29a2c23bc9 Remove deprecated nova_create_flavors.sh script
nova_create_flavors.sh has been deprecated for over a year (since 2013-05-07)

Removing the script, since it is not documented in any current READMEs
or on the Openstack wiki.

Change-Id: Ib6031c2518b8e6d43bb692e0f687a2e287ec494f
Partial-Bug: 1338066
2014-07-18 09:55:58 -04:00
Thomas Herve
2a51ee7449 Migrate to oslo.db
Move from oslo-incubator db module to oslo.db

Change-Id: I485375e3defc807e1fc272803a064b2c52e8ac13
2014-07-15 10:14:56 +02:00
Thomas Herve
9090b988e6 Port to oslo.messaging
Move from oslo RPC to oslo.messaging.

Implements: blueprint oslo-messaging
Co-Authored-By: sdake@redhat.com
Change-Id: I2d222c248dd2cd405b8ec35c4c8198ed001fb69f
2014-06-26 06:45:52 +02:00
Thomas Herve
7f7817c157 Sync with oslo incubator
Sync with oslo incubator at 45890dae35cd14a25175cdce7c12a5f9acbd712f

Change-Id: I44ecc69f1d952061be7cb2f41678b879ded93eae
2014-06-17 11:22:37 +02:00
Jenkins
cc07a851b0 Merge "Use entry points for config generation" 2014-06-10 11:57:58 +00:00
Jenkins
515bf7d48d Merge "Fix requirements_style_check on BSD platforms" 2014-06-09 17:24:47 +00:00
Anderson Mesquita
797dcc8dc1 Fix requirements_style_check on BSD platforms
On Linux, the sort command implicitly ignore non-alphanumeric characters
when sorting.  Since the '>' character has an ASCII value greater than
the '-' character, the following list will be sorted on Linux, but not
on a Mac:

SQLAlchemy>=0.7.8,<=0.9.99
sqlalchemy-migrate>=0.9.1

This makes sort explicitly ignore such characters and will keep the
tests consistent across different environments.

Closes-Bug: #1324945
Change-Id: I559ae4b4c3e2a7d190af9d4b1517dfaf23d114b1
2014-06-02 11:59:35 -04:00
Thomas Herve
52ad1edea2 Use entry points for config generation
This starts using entry points to generate configuration for the
common.config and the common.wsgi modules, as they use entries with the
same name in different groups.
This also removes configuration for sslutils which is unused, and
re-enable the check for up-to-date configuration.

Co-Authored-By: ala.rezmerita@cloudwatt.com
Closes-Bug: #1288586
Change-Id: If48c62bbb2b1fb641791dad56f7f905e483080fa
2014-05-30 16:21:03 +02:00
Christian Berendt
318669f408 removed deprecated tools
* tools/experimental_ssh_eventlet.py
  * tools/state_transitions.py

Change-Id: I6fd8642bcabab16bb7062637d7b8b864f09f1c80
2014-05-25 23:11:35 +02:00
Thomas Herve
7b589f9000 Sync oslo incubator
Sync with oslo incubator at commit
ea9ead81417e942495f3cc19be400801e7aa9cb4 to get the new config generator
script options.

Change-Id: I52e006325d5cf7ea731d85a73fb7c3675f1f7e41
2014-05-21 21:16:36 +02:00
Clint Byrum
e8ab2b4745 Distribute create_heat_domain
Rename it to heat-keystone-setup-domain and ship it in bin with the
other helper scripts. This will make it consumable by automated systems
and packaging.

Change-Id: I7914869377cd08b6201007aa0eb6b8a70d763254
2014-04-25 21:13:12 -07:00
Clint Byrum
1f6ad08d0a Fix all flake8 problems.
Change-Id: Ibd36add2530a144122a0c3a88f31b3df1b838d24
2014-04-25 21:13:12 -07:00
Clint Byrum
62044fadd9 Order and separate imports properly
Alphabetical and separated into system modules and libs.

Change-Id: I367245b10ca428d68350e3f010c17dea7e38fe67
2014-04-25 21:13:12 -07:00