Gerrit used to allow regexps in topic: queries, but now topic: is only
for exact matches. intopic: can be used to search within topics.
Change-Id: Icc5c80ead124b4383198915984543a7987b1bf2e
You're not supposed to just randomly put backslashes in front of other
characters that don't need escaping unless it's a raw string. This is
deprecated in Python 3.6.
Change-Id: I7a69ba6dd10412bb065f2b6ba405840d0a98663a
This makes tox use the latest version of the tool from os-testr repo,
which contains some valuable changes, like the one making the gate fail
if for some reason no tests are executed because all of them are
skipped.
Change-Id: If88be4b310d746ccc885e3d0c1db8a4dfabb2a28
If resource has available_resource_mapping method and
it's not available, custom guidelines check will skip it,
which is incorrect. This patch improves list of resources:
now only hidden, contrib and manually excluded resources
don't checked.
Change-Id: Ic2cb37fb3fe4aefb8b3efb911aecf46155541469
Closes-bug: #1674949
Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.
This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.
See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html
Update HACKING for this.
Needed-By: I98c1b799e520cad102b9e47cf51477f54b07e732
Change-Id: Id5e3b67190866acdebee2b89f4393d5c407a5b96
In some merge issues files or modules can be removed, but
still registered in global env. In that cases custom guidelines
raises an error with the message "No such file or directory".
Add exception handling to avoid error raising. Instead of error,
call warning and skip such class.
Change-Id: I71af2fffc2bdec414cb68c40eaf3268fe81134de
Closes-bug: #1613669
Global environment during registering resources also load resources from
/etc/environment.d . As result it loads two resources mapped on
templates:
- 'AWS::CloudWatch::Alarm'
- 'AWS::RDS::DBInstance'
However execute guideline checks for these resources is not possible due
to these resources use template_resource object and can not be processed
as usual *.py file.
This patch add ignoring for these two resource types.
Note: this error is not displayed on pep8 gate job due to we don't
install devstack during execution this job, but this error affects all
environments with installed devstack.
Closes-Bug: #1552194
Change-Id: I29abdfa1a4f4a17dfbcdaaf6f0c6665359bab17a
There are several trailing spaces error raised by
custom guidelines check. Need to fix them for successful
pep8 running.
implements bp custom-guidelines
Change-Id: Ibf50208155315e75795d7b9c8a8dbe487f9046ac
There are several method error raised during custom
guidelines check. Need to fix it for successful running
pep8.
implements bp custom-guidelines
Change-Id: I55883bb8d314f982161aaa21c010e9d1467bf903
There're several errors, raised by custom guidelines check,
need to fix it for successful pep8 running.
implements bp custom-guidelines
Change-Id: Ibef41cad9b20715a740cedac7b98e9647bd3d6b7
There are several errors during attributes descriptions
checking by custom guidelines. Need to fix them for
successful pep8 running.
implements bp custom-guidelines
Change-Id: I3df75c6343217723fd4490f9e70eb2d8499eb5ae
There are several errors, raised during properties schemas
checking by custom guidelines. Need to fix them for successful
pep8 running.
implements bp custom-guidelines
Change-Id: Icd24498b8d36106412a61d4b82b00eb92095ffe9
* Tests were skipped due to a mox3 bug. The bug has now been fixed
and there's a new release of mox3. Unskip it.
* Remove the tool run-py3-tests.sh which isn't needed anymore.
blueprint heat-python34-support
Change-Id: I304d87e4313148c10a2465bf92ae932f525bb4ce
Also, fix minor flake8 issue related to Long literal.
This should now have the python34 gate job passing.
partial blueprint heat-python34-support
Change-Id: I7f85e7251fc96587df0b43daac202c38542a6f6c
With the incorporation of many projects within OpenStack, it's very important to
use standards in the documentation This is important for formalization as well
as consistency
the proper usage is: heat or Orchestration or Orchestration module
heat should not be capitalized
https://wiki.openstack.org/wiki/Documentation/Conventions
Change-Id: Ia8d7f1429f877e4c88fc9b210948b63443376ba0
As a help for new developers add lists of RPM/DEB packages to install
on a clean new system in order to successfully run
Heat's unit test suit locally.
Also, update tools/README
Change-Id: Ibed2b7b9d9eef34d88ce667c82020a1980d98646
Replace usage of old incubator configuration generator by the
oslo.config tool.
tools/config/generate_sample.sh has been replaced by tox -egenconfig.
heat_integrationtests/generate_sample.sh has been replaced by
oslo-config-generator
--config-file=heat_integrationtests/config-generator.conf
Change-Id: I6d95df203b556c8ec2088d40a446427f7087b9a7
- added full log for integration tests by default
- added env 'py27log' which allows to get log for unit-tests
Change-Id: I43ca330c82ffe100247102021fce1f00acb4d11a
This tool is deprecated in favor of tox for a long time already.
Moreover, currently it is broken as it tries to run
our in-tree integration tests as well.
So instead of fixing it, just finally remove it.
Change-Id: Icb3c4d423031456b8b24a84e97e310df077d9990
Our gate is currently broken due to an oslo library release,
so remove this check while we move to removing the sample config
(which requires changes to devstack to use tox -egenconfig)
Change-Id: Id4a37e9a5be156fea05c96e385c23da016ea9e69
This module isn't referenced in openstack-common.conf and is unused
so remove it
Change-Id: I602f40c511095818a8aee5f342029993bd470de4
Partial-Bug: #1380629
There's references to the auth_token middleware in keystoncelient.
The auth_token middleware has been moved to keystonemiddleware and
the version in keystoneclient shouldn't be used anymore.
If these references aren't updated, then when options are changed in
keystonemiddleware.auth_token the heat-api will fail to start because
there's duplicate options in keystoneclient.middleware.auth_token.
Change-Id: I04573aa5ff967afe3e00329f797fcc71b779e7b3
Closes-Bug: #1379082
rst2script.sed was referenced in the Fedora getting started
documentation, but the recommended way to use Heat/Openstack
on Fedora is now to use RDO/packstack.
Also removes the reference to rst2script.sed in the
getting_started/on_fedora documentation.
Also removes obsolete integration.sh script.
Partial-Bug: 1338066
Change-Id: I7f2b0d84ccef324ccb8e32ca4c6d90f9a3f2dda3
Remove instructions for:
experimental_ssh_eventlet.py: deleted May 25, 2014 commit 318669f
openstack: deleted Sep 30, 2013 commit f4a9c0f
heat-keystone-setup: was never in the tools directory, but has
documentation in the man pages
Change-Id: I8ae3050e16163699849342e81d302942e763ac0c
Partial-Bug: 1338066
glance-jeos-add-from-github.sh has not been edited since 2012-08-20, and
its image links have been broken (according to Google cache) for a
minimum of 9 months.
The functionality of the script seems to be superceded by the
handy-dandy diskimage-builder tool.
See http://docs.openstack.org/developer/heat/getting_started/jeos_building.html
for more info about diskimage-builder workflow.
Change-Id: I99880f1cca4af84fa7193d749a7c8f6957bb0b78
Partial-Bug: 1338066
nova_create_flavors.sh has been deprecated for over a year (since 2013-05-07)
Removing the script, since it is not documented in any current READMEs
or on the Openstack wiki.
Change-Id: Ib6031c2518b8e6d43bb692e0f687a2e287ec494f
Partial-Bug: 1338066
Move from oslo RPC to oslo.messaging.
Implements: blueprint oslo-messaging
Co-Authored-By: sdake@redhat.com
Change-Id: I2d222c248dd2cd405b8ec35c4c8198ed001fb69f
On Linux, the sort command implicitly ignore non-alphanumeric characters
when sorting. Since the '>' character has an ASCII value greater than
the '-' character, the following list will be sorted on Linux, but not
on a Mac:
SQLAlchemy>=0.7.8,<=0.9.99
sqlalchemy-migrate>=0.9.1
This makes sort explicitly ignore such characters and will keep the
tests consistent across different environments.
Closes-Bug: #1324945
Change-Id: I559ae4b4c3e2a7d190af9d4b1517dfaf23d114b1
This starts using entry points to generate configuration for the
common.config and the common.wsgi modules, as they use entries with the
same name in different groups.
This also removes configuration for sslutils which is unused, and
re-enable the check for up-to-date configuration.
Co-Authored-By: ala.rezmerita@cloudwatt.com
Closes-Bug: #1288586
Change-Id: If48c62bbb2b1fb641791dad56f7f905e483080fa
Sync with oslo incubator at commit
ea9ead81417e942495f3cc19be400801e7aa9cb4 to get the new config generator
script options.
Change-Id: I52e006325d5cf7ea731d85a73fb7c3675f1f7e41
Rename it to heat-keystone-setup-domain and ship it in bin with the
other helper scripts. This will make it consumable by automated systems
and packaging.
Change-Id: I7914869377cd08b6201007aa0eb6b8a70d763254