openstack/horizon
Code Issues Proposed changes

Merge "No more no-extra-parens eslint errors"

Browse Source
This commit is contained in:
Jenkins 2016-07-27 07:37:05 +00:00 committed by Gerrit Code Review
commit 02043a98cb
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
horizon/static/framework/util/filters/filters.js
View File

@ -133,7 +133,7 @@
function noValueFilter() { function noValueFilter() {
return function (input, def) { return function (input, def) {
if (input === null || angular.isUndefined(input) || if (input === null || angular.isUndefined(input) ||
(angular.isString(input) && '' === input.trim())) { angular.isString(input) && '' === input.trim()) {
return def || gettext('-'); return def || gettext('-');
} else { } else {
return input; return input;
@ -208,9 +208,9 @@
function itemCountFilter() { function itemCountFilter() {
function ensureNonNegative(input) { function ensureNonNegative(input) {
var isNumeric = (input !== null && isFinite(input)); var isNumeric = input !== null && isFinite(input);
var number = isNumeric ? Math.round(input) : 0; var number = isNumeric ? Math.round(input) : 0;
return (number > 0) ? number : 0; return number > 0 ? number : 0;
} }
return function (input, totalInput) { return function (input, totalInput) {

2
horizon/static/framework/util/validators/hz-password-match.directive.js
View File

@ -70,7 +70,7 @@
// helper function to check that password matches // helper function to check that password matches
function passwordCheck() { function passwordCheck() {
scope.$apply(function () { scope.$apply(function () {
var match = (ctrl.$modelValue === pwElement.val()); var match = ctrl.$modelValue === pwElement.val();
ctrl.$setValidity('match', match); ctrl.$setValidity('match', match);
}); });
} }

4
horizon/static/framework/widgets/magic-search/hz-magic-search-context.directive.js
View File

@ -106,9 +106,9 @@
cancel: gettext('Cancel'), cancel: gettext('Cancel'),
prompt: gettext('Click here for filters.'), prompt: gettext('Click here for filters.'),
remove: gettext('Remove'), remove: gettext('Remove'),
text: (scope.clientFullTextSearch text: scope.clientFullTextSearch
? gettext('Search in current results') ? gettext('Search in current results')
: gettext('Full Text Search')) : gettext('Full Text Search')
}; };
scope.filterStrings = filterStrings || defaultFilterStrings; scope.filterStrings = filterStrings || defaultFilterStrings;

2
horizon/static/framework/widgets/wizard/wizard.controller.js
View File

@ -190,7 +190,7 @@
} }
}); });
viewModel.ready = (stepReadyPromises.length === 0); viewModel.ready = stepReadyPromises.length === 0;
return $q.all(stepReadyPromises); return $q.all(stepReadyPromises);
} }