From 08e0f38c843816660e2b2930c7c6ee5c0435b4a3 Mon Sep 17 00:00:00 2001 From: Vladislav Kuzmin Date: Tue, 3 Jul 2018 18:30:09 +0400 Subject: [PATCH] Fix image description field Nothing changed when edit image description on Angularized panel. This patch fixes it. Change-Id: I29fb643bfa9b648ad24fcb9888c658a5a52e4bcc Closes-Bug: #1779879 --- .../static/app/core/images/actions/edit.action.service.js | 3 ++- .../app/core/images/actions/edit.action.service.spec.js | 2 +- releasenotes/notes/image-description-3fc00c02f46a80c7.yaml | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/image-description-3fc00c02f46a80c7.yaml diff --git a/openstack_dashboard/static/app/core/images/actions/edit.action.service.js b/openstack_dashboard/static/app/core/images/actions/edit.action.service.js index 014bf3fd0d..822d6fec56 100644 --- a/openstack_dashboard/static/app/core/images/actions/edit.action.service.js +++ b/openstack_dashboard/static/app/core/images/actions/edit.action.service.js @@ -103,7 +103,8 @@ .then(onMetadataGet); function onMetadataGet(response) { - var updated = metadata; + var updated = metadata || Object(); + updated.description = image.properties.description; var removed = angular.copy(response.data); angular.forEach(updated, function(value, key) { delete removed[key]; diff --git a/openstack_dashboard/static/app/core/images/actions/edit.action.service.spec.js b/openstack_dashboard/static/app/core/images/actions/edit.action.service.spec.js index 34d20f43ef..1d4101d54a 100644 --- a/openstack_dashboard/static/app/core/images/actions/edit.action.service.spec.js +++ b/openstack_dashboard/static/app/core/images/actions/edit.action.service.spec.js @@ -19,7 +19,7 @@ describe('horizon.app.core.images.actions.edit.service', function() { var service, $scope, $q, deferred, $timeout, updateImageDeferred; - var image = {id: 1, name: 'Original'}; + var image = {id: 1, name: 'Original', properties: {description: 'bla-bla'}}; var existingMetadata = {p1: '1', p2: '2'}; var metadataService = { diff --git a/releasenotes/notes/image-description-3fc00c02f46a80c7.yaml b/releasenotes/notes/image-description-3fc00c02f46a80c7.yaml new file mode 100644 index 0000000000..a0b5c7322c --- /dev/null +++ b/releasenotes/notes/image-description-3fc00c02f46a80c7.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fix an error on image description field when it is changed + in the Angularized panel [:bug: `1779879`]