openstack/horizon
Code Issues Proposed changes

Remove unused 'not_list' template argument

Browse Source 
This is unused in Horizon itself and I didn't find any
references in plugins. Undefined variable leads to
errors during render in a debug mode.

Partial-Bug: #1720893

Change-Id: I9de0b24adfeb48f5fe14676aaec6b17b8eb52207
This commit is contained in:
Ivan Kolodyazhny 2019-09-09 17:28:46 +03:00
parent 8343014ece
commit 86d13968d8
5 changed files with 99 additions and 140 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstack_dashboard/contrib/developer/profiler/templates/profiler/_mode_picker.html
View File

@ -1,8 +1,4 @@
{% if not_list %}
<div class="dropdown" ng-controller="profilerActionsController as ctrl">
{% else %}
<li class="dropdown" ng-controller="profilerActionsController as ctrl"> <li class="dropdown" ng-controller="profilerActionsController as ctrl">
{% endif %}
<a data-toggle="dropdown" href="#" class="dropdown-toggle" role="button" <a data-toggle="dropdown" href="#" class="dropdown-toggle" role="button"
aria-expanded="false"> aria-expanded="false">
<span class="fa fa-calculator"></span> <span class="fa fa-calculator"></span>
@ -14,8 +10,4 @@
<span class="fa fa-refresh"></span> Profile Current Page <span class="fa fa-refresh"></span> Profile Current Page
</a></li> </a></li>
</ul> </ul>
{% if not_list %}
</div>
{% else %}
</li> </li>
{% endif %}

11
openstack_dashboard/templates/header/_context_selection.html
View File

@ -1,11 +1,7 @@
{% load context_selection %} {% load context_selection %}
{% if not_list %}
<div class="dropdown">
{% else %}
<li class="dropdown"> <li class="dropdown">
{% endif %} <a class="dropdown-toggle" role="button" aria-expanded="false" data-toggle="dropdown" href="#">
<a class="dropdown-toggle{% if not_list %} btn btn-primary{% endif %}" role="button" aria-expanded="false" data-toggle="dropdown" href="#">
{% show_overview %} {% show_overview %}
<span class="fa fa-caret-down"></span> <span class="fa fa-caret-down"></span>
</a> </a>
@ -34,9 +30,4 @@
</li> </li>
{% endif %} {% endif %}
</ul> </ul>
{% if not_list %}
</div>
{% else %}
</li> </li>
{% endif %}

8
openstack_dashboard/templates/header/_keystone_provider_selection.html
View File

@ -1,11 +1,3 @@
{% if not_list %}
<div class="dropdown">
{% else %}
<li class="dropdown"> <li class="dropdown">
{% endif %}
{% include "horizon/common/_keystone_provider_selector.html" %} {% include "horizon/common/_keystone_provider_selector.html" %}
{% if not_list %}
</div>
{% else %}
</li> </li>
{% endif %}

8
openstack_dashboard/templates/header/_region_selection.html
View File

@ -1,11 +1,3 @@
{% if not_list %}
<div class="dropdown">
{% else %}
<li class="dropdown"> <li class="dropdown">
{% endif %}
{% include "horizon/common/_region_selector.html" %} {% include "horizon/common/_region_selector.html" %}
{% if not_list %}
</div>
{% else %}
</li> </li>
{% endif %}

8
openstack_dashboard/templates/header/_user_menu.html
View File

@ -1,11 +1,7 @@
{% load i18n %} {% load i18n %}
{% load themes %} {% load themes %}
{% if not_list %}
<div class="dropdown user-menu">
{% else %}
<li class="dropdown user-menu"> <li class="dropdown user-menu">
{% endif %}
<a data-toggle="dropdown" href="#" class="dropdown-toggle" role="button" aria-expanded="false"> <a data-toggle="dropdown" href="#" class="dropdown-toggle" role="button" aria-expanded="false">
<span class="fa fa-user"></span> <span class="fa fa-user"></span>
<span class="user-name">{{ request.user.username }}</span> <span class="user-name">{{ request.user.username }}</span>
@ -69,8 +65,4 @@
</a> </a>
</li> </li>
</ul> </ul>
{% if not_list %}
</div>
{% else %}
</li> </li>
{% endif %}