openstack/horizon
Code Issues Proposed changes

Fix qos and trunks tables

Browse Source 
When replacing deprecated custom callback methods success()/error()
with then()/catch(), we need to keep in mind that methods' signatures
and return values are different, so we need to explicitly return the
response value when using then(function onSuccess(response){}).

Closes-Bug: #2018232

Change-Id: I9d6d769075753c6395db2530a8d60ec28cafdc3d
This commit is contained in:
Tatiana Ovchinnikova 2023-05-09 14:04:35 -05:00
parent dc2a2fd577
commit c770785dcf
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js
View File

@ -376,6 +376,7 @@
var promise = apiService.get('/api/neutron/qos_policies/' + id + '/') var promise = apiService.get('/api/neutron/qos_policies/' + id + '/')
.then(function onSuccess(response) { .then(function onSuccess(response) {
convertDatesHumanReadable(response.data); convertDatesHumanReadable(response.data);
return response;
}); });
promise = suppressError ? promise : promise.catch(function onError() { promise = suppressError ? promise : promise.catch(function onError() {
var msg = gettext('Unable to retrieve the policy with ID %(id)s'); var msg = gettext('Unable to retrieve the policy with ID %(id)s');
@ -398,6 +399,7 @@
response.data.items.forEach(function(policy) { response.data.items.forEach(function(policy) {
convertDatesHumanReadable(policy); convertDatesHumanReadable(policy);
}); });
return response;
}) })
.catch(function onError() { .catch(function onError() {
toastService.add('error', gettext('Unable to retrieve the qos policies.')); toastService.add('error', gettext('Unable to retrieve the qos policies.'));
@ -812,6 +814,7 @@
var promise = apiService.get('/api/neutron/trunks/' + id + '/') var promise = apiService.get('/api/neutron/trunks/' + id + '/')
.then(function onSuccess(response) { .then(function onSuccess(response) {
convertDatesHumanReadable(response.data); convertDatesHumanReadable(response.data);
return response;
}); });
promise = suppressError ? promise : promise.catch(function onError() { promise = suppressError ? promise : promise.catch(function onError() {
var msg = gettext('Unable to retrieve the trunk with id: %(id)s'); var msg = gettext('Unable to retrieve the trunk with id: %(id)s');
@ -834,6 +837,7 @@
response.data.items.forEach(function(trunk) { response.data.items.forEach(function(trunk) {
convertDatesHumanReadable(trunk); convertDatesHumanReadable(trunk);
}); });
return response;
}) })
.catch(function onError() { .catch(function onError() {
toastService.add('error', gettext('Unable to retrieve the trunks.')); toastService.add('error', gettext('Unable to retrieve the trunks.'));