openstack/horizon
Code Issues Proposed changes

Fix table rendering for iterable objects

Browse Source 
Table rendering is broken for objects which are iterable but do NOT
implement a 'get' method. This patch ensures that we don't try to
invoke a 'get' method on objects which don't support it.

Change-Id: If29946f8c553b85a03ea6c50b0cf74f3ba787d0b
Closes-Bug: #1278956
This commit is contained in:
Brian DeHamer
2014-02-11 10:13:19 -08:00
parent cf252d2252
commit c93f228671
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
horizon/tables/base.py
View File

@@ -307,7 +307,7 @@ class Column(html.HTMLElement):
if callable(self.transform): if callable(self.transform):
data = self.transform(datum) data = self.transform(datum)
# Dict lookups # Dict lookups
elif isinstance(datum, collections.Iterable) and \ elif isinstance(datum, collections.Mapping) and \
self.transform in datum: self.transform in datum:
data = datum.get(self.transform) data = datum.get(self.transform)
else: else: