openstack/horizon
Code Issues Proposed changes

Try to avoid intermittent test_dashboard_help_redirection failure

Browse Source 
Assuming that the additional browser window is actually opened after
we command test to switch to it, swap these 2 commands. If it doesn't
help, remove the failing test, because ensuring good network
connectivity to external URLs is out of integration tests scope.

Change-Id: I2c972a9ac813f30bb2ea7e6e7d366f729fd90bfb
Related-Bug: #1520582
This commit is contained in:
Timur Sufiev 2015-11-27 17:24:12 +03:00
parent ab7d5c3ec5
commit f523af9bed
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstack_dashboard/test/integration_tests/tests/test_dashboard_help_redirection.py
View File

@ -19,10 +19,10 @@ class TestDashboardHelp(helpers.TestCase):
"""Verifies Help link redirects to the right URL."""
self.home_pg.go_to_help_page()
self.home_pg.switch_window()
self.home_pg._wait_until(
lambda _: self.home_pg.is_nth_window_opened(2))
self.home_pg.switch_window()
self.assertEqual(self.CONFIG.dashboard.help_url,
self.home_pg.get_url_current_page(),
"help link did not redirect to the right URL")