Files
horizon/openstack_dashboard/dashboards/admin/vg_snapshots/views.py
Akihiro Motoki e5d09edc20 Use python3-style super()
In python3, super() does not always require a class and self reference.
In other words, super() is enough for most cases.
This is much simpler and it is time to switch it to the newer style.

pylint provides a check for this.
Let's enable 'super-with-arguments' check.

NOTE: _prepare_mappings() method of FormRegion in
openstack_dashboard/test/integration_tests/regions/forms.py is refactored.
super() (without explicit class and self referece) does not work when
a subclass method calls a same method in a parent class multiple times.
It looks better to prepare a separate method to provide a common logic.

Change-Id: Id9512a14be9f20dbd5ebd63d446570c7b7c825ff
2020-10-15 14:37:20 +09:00

86 lines
3.2 KiB
Python

# Copyright 2019 NEC Corporation
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from django.urls import reverse
from django.utils.translation import ugettext_lazy as _
from horizon import exceptions
from horizon import tables
from openstack_dashboard import api
from openstack_dashboard.dashboards.admin.vg_snapshots \
import tables as admin_tables
from openstack_dashboard.dashboards.admin.vg_snapshots \
import tabs as admin_tabs
from openstack_dashboard.dashboards.project.vg_snapshots \
import views as project_views
INDEX_URL = "horizon:admin:vg_snapshots:index"
class IndexView(tables.DataTableView):
table_class = admin_tables.GroupSnapshotsTable
page_title = _("Group Snapshots")
def get_data(self):
try:
vg_snapshots = api.cinder.group_snapshot_list(
self.request, {'all_tenants': 1})
except Exception:
vg_snapshots = []
exceptions.handle(self.request, _("Unable to retrieve "
"volume group snapshots."))
try:
groups = dict((g.id, g) for g
in api.cinder.group_list(self.request,
{'all_tenants': 1}))
except Exception:
groups = {}
exceptions.handle(self.request,
_("Unable to retrieve volume groups."))
# Gather our tenants to correlate against Group IDs
try:
tenants, has_more = api.keystone.tenant_list(self.request)
except Exception:
tenants = []
msg = _('Unable to retrieve group snapshot project information.')
exceptions.handle(self.request, msg)
tenant_dict = dict((t.id, t) for t in tenants)
for vg_snapshot in vg_snapshots:
vg_snapshot.group = groups.get(vg_snapshot.group_id)
tenant_id = getattr(vg_snapshot, "project_id", None)
tenant = tenant_dict.get(tenant_id)
# NOTE: If horizon is using cinder API microversion below '3.58',
# it doesn't include any 'project id' information in group
# snapshot's object.
vg_snapshot.tenant_name = getattr(tenant, "name", None)
return vg_snapshots
class DetailView(project_views.DetailView):
tab_group_class = admin_tabs.DetailTabs
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
table = admin_tables.GroupSnapshotsTable(self.request)
context["actions"] = table.render_row_actions(context["vg_snapshot"])
return context
@staticmethod
def get_redirect_url():
return reverse(INDEX_URL)