ed076e6234
If none of the floating IPs listed within Horizon are attached to an instance, do not request a list of Nova instances (because we have no use for it). Apply the same behavior for Volumes tab (both Admin and Project). This patch both saves us from making unnecessary and potentially expensive call to Nova and lays the ground for a more selective request of instance details from Nova. The latter will be possible once Nova supports filtering instance details by >1 instance_id. For reference see https://blueprints.launchpad.net/nova/+spec/get-multi-servers-filter Change-Id: Ie7563b9e03b286b4cf51507463213162af3383b1 Partial-Bug: #1442310
381 lines
17 KiB
Python
381 lines
17 KiB
Python
# Copyright 2012 Nebula, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import copy
|
|
|
|
from django.conf import settings
|
|
from django.core.urlresolvers import reverse
|
|
from django import http
|
|
from django.test.utils import override_settings
|
|
|
|
from mox3.mox import IsA # noqa
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.project.volumes.backups \
|
|
import tables as backup_tables
|
|
from openstack_dashboard.dashboards.project.volumes.snapshots \
|
|
import tables as snapshot_tables
|
|
from openstack_dashboard.dashboards.project.volumes.volumes \
|
|
import tables as volume_tables
|
|
from openstack_dashboard.test import helpers as test
|
|
|
|
|
|
INDEX_URL = reverse('horizon:project:volumes:index')
|
|
VOLUME_SNAPSHOTS_TAB_URL = reverse('horizon:project:volumes:snapshots_tab')
|
|
VOLUME_BACKUPS_TAB_URL = reverse('horizon:project:volumes:backups_tab')
|
|
|
|
|
|
class VolumeAndSnapshotsAndBackupsTests(test.TestCase):
|
|
@test.create_stubs({api.cinder: ('tenant_absolute_limits',
|
|
'volume_list',
|
|
'volume_list_paged',
|
|
'volume_snapshot_list',
|
|
'volume_snapshot_list_paged',
|
|
'volume_backup_supported',
|
|
'volume_backup_list_paged',
|
|
),
|
|
api.nova: ('server_list',)})
|
|
def _test_index(self, backup_supported=True, instanceless_volumes=False):
|
|
vol_backups = self.cinder_volume_backups.list()
|
|
vol_snaps = self.cinder_volume_snapshots.list()
|
|
volumes = self.cinder_volumes.list()
|
|
if instanceless_volumes:
|
|
for volume in volumes:
|
|
volume.attachments = []
|
|
|
|
api.cinder.volume_backup_supported(IsA(http.HttpRequest)).\
|
|
MultipleTimes().AndReturn(backup_supported)
|
|
api.cinder.volume_list_paged(
|
|
IsA(http.HttpRequest), marker=None, search_opts=None,
|
|
sort_dir='desc', paginate=True).\
|
|
AndReturn([volumes, False, False])
|
|
if not instanceless_volumes:
|
|
api.nova.server_list(IsA(http.HttpRequest), search_opts=None).\
|
|
AndReturn([self.servers.list(), False])
|
|
api.cinder.volume_snapshot_list(IsA(http.HttpRequest)).\
|
|
AndReturn(vol_snaps)
|
|
|
|
api.cinder.volume_snapshot_list_paged(
|
|
IsA(http.HttpRequest), paginate=True, marker=None,
|
|
sort_dir='desc').AndReturn([vol_snaps, False, False])
|
|
api.cinder.volume_list(IsA(http.HttpRequest)).AndReturn(volumes)
|
|
if backup_supported:
|
|
api.cinder.volume_backup_list_paged(
|
|
IsA(http.HttpRequest), marker=None, sort_dir='desc',
|
|
paginate=True).AndReturn([vol_backups, False, False])
|
|
api.cinder.volume_list(IsA(http.HttpRequest)).AndReturn(volumes)
|
|
api.cinder.tenant_absolute_limits(IsA(http.HttpRequest)).\
|
|
MultipleTimes().AndReturn(self.cinder_limits['absolute'])
|
|
self.mox.ReplayAll()
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
# Explicitly load the other tabs. If this doesn't work the test
|
|
# will fail due to "Expected methods never called."
|
|
res = self.client.get(VOLUME_SNAPSHOTS_TAB_URL)
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
if backup_supported:
|
|
res = self.client.get(VOLUME_BACKUPS_TAB_URL)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
def test_index_backup_supported(self):
|
|
self._test_index(backup_supported=True)
|
|
|
|
def test_index_backup_not_supported(self):
|
|
self._test_index(backup_supported=False)
|
|
|
|
def test_index_no_volume_attachments(self):
|
|
self._test_index(instanceless_volumes=True)
|
|
|
|
@test.create_stubs({api.cinder: ('tenant_absolute_limits',
|
|
'volume_list_paged',
|
|
'volume_backup_supported',
|
|
),
|
|
api.nova: ('server_list',)})
|
|
def _test_index_paginated(self, marker, sort_dir, volumes, url,
|
|
has_more, has_prev):
|
|
backup_supported = True
|
|
|
|
api.cinder.volume_backup_supported(IsA(http.HttpRequest)).\
|
|
MultipleTimes().AndReturn(backup_supported)
|
|
api.cinder.volume_list_paged(IsA(http.HttpRequest), marker=marker,
|
|
sort_dir=sort_dir, search_opts=None,
|
|
paginate=True).\
|
|
AndReturn([volumes, has_more, has_prev])
|
|
api.nova.server_list(IsA(http.HttpRequest), search_opts=None).\
|
|
AndReturn([self.servers.list(), False])
|
|
api.cinder.tenant_absolute_limits(IsA(http.HttpRequest)).MultipleTimes().\
|
|
AndReturn(self.cinder_limits['absolute'])
|
|
self.mox.ReplayAll()
|
|
|
|
res = self.client.get(url)
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
self.mox.UnsetStubs()
|
|
return res
|
|
|
|
def ensure_attachments_exist(self, volumes):
|
|
volumes = copy.copy(volumes)
|
|
for volume in volumes:
|
|
if not volume.attachments:
|
|
volume.attachments.append({
|
|
"id": "1", "server_id": '1', "device": "/dev/hda"})
|
|
return volumes
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=2)
|
|
def test_index_paginated(self):
|
|
mox_volumes = self.ensure_attachments_exist(self.cinder_volumes.list())
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
|
|
# get first page
|
|
expected_volumes = mox_volumes[:size]
|
|
url = INDEX_URL
|
|
res = self._test_index_paginated(marker=None, sort_dir="desc",
|
|
volumes=expected_volumes, url=url,
|
|
has_more=True, has_prev=False)
|
|
volumes = res.context['volumes_table'].data
|
|
self.assertItemsEqual(volumes, expected_volumes)
|
|
|
|
# get second page
|
|
expected_volumes = mox_volumes[size:2 * size]
|
|
marker = expected_volumes[0].id
|
|
next = volume_tables.VolumesTable._meta.pagination_param
|
|
url = "?".join([INDEX_URL, "=".join([next, marker])])
|
|
res = self._test_index_paginated(marker=marker, sort_dir="desc",
|
|
volumes=expected_volumes, url=url,
|
|
has_more=True, has_prev=True)
|
|
volumes = res.context['volumes_table'].data
|
|
self.assertItemsEqual(volumes, expected_volumes)
|
|
|
|
# get last page
|
|
expected_volumes = mox_volumes[-size:]
|
|
marker = expected_volumes[0].id
|
|
next = volume_tables.VolumesTable._meta.pagination_param
|
|
url = "?".join([INDEX_URL, "=".join([next, marker])])
|
|
res = self._test_index_paginated(marker=marker, sort_dir="desc",
|
|
volumes=expected_volumes, url=url,
|
|
has_more=False, has_prev=True)
|
|
volumes = res.context['volumes_table'].data
|
|
self.assertItemsEqual(volumes, expected_volumes)
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=2)
|
|
def test_index_paginated_prev_page(self):
|
|
mox_volumes = self.ensure_attachments_exist(self.cinder_volumes.list())
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
|
|
# prev from some page
|
|
expected_volumes = mox_volumes[size:2 * size]
|
|
marker = expected_volumes[0].id
|
|
prev = volume_tables.VolumesTable._meta.prev_pagination_param
|
|
url = "?".join([INDEX_URL, "=".join([prev, marker])])
|
|
res = self._test_index_paginated(marker=marker, sort_dir="asc",
|
|
volumes=expected_volumes, url=url,
|
|
has_more=True, has_prev=True)
|
|
volumes = res.context['volumes_table'].data
|
|
self.assertItemsEqual(volumes, expected_volumes)
|
|
|
|
# back to first page
|
|
expected_volumes = mox_volumes[:size]
|
|
marker = expected_volumes[0].id
|
|
prev = volume_tables.VolumesTable._meta.prev_pagination_param
|
|
url = "?".join([INDEX_URL, "=".join([prev, marker])])
|
|
res = self._test_index_paginated(marker=marker, sort_dir="asc",
|
|
volumes=expected_volumes, url=url,
|
|
has_more=True, has_prev=False)
|
|
volumes = res.context['volumes_table'].data
|
|
self.assertItemsEqual(volumes, expected_volumes)
|
|
|
|
@test.create_stubs({api.cinder: ('tenant_absolute_limits',
|
|
'volume_snapshot_list_paged',
|
|
'volume_list',
|
|
'volume_backup_supported',
|
|
),
|
|
api.nova: ('server_list',)})
|
|
def _test_snapshots_index_paginated(self, marker, sort_dir, snapshots, url,
|
|
has_more, has_prev):
|
|
backup_supported = True
|
|
|
|
api.cinder.volume_backup_supported(IsA(http.HttpRequest)).\
|
|
MultipleTimes().AndReturn(backup_supported)
|
|
api.cinder.volume_snapshot_list_paged(
|
|
IsA(http.HttpRequest), marker=marker, sort_dir=sort_dir,
|
|
paginate=True).AndReturn([snapshots, has_more, has_prev])
|
|
api.cinder.volume_list(IsA(http.HttpRequest)).AndReturn(
|
|
self.cinder_volumes.list())
|
|
self.mox.ReplayAll()
|
|
|
|
res = self.client.get(url)
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
self.mox.UnsetStubs()
|
|
return res
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=1)
|
|
def test_snapshots_index_paginated(self):
|
|
mox_snapshots = self.cinder_volume_snapshots.list()
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
base_url = reverse('horizon:project:volumes:snapshots_tab')
|
|
next = snapshot_tables.VolumeSnapshotsTable._meta.pagination_param
|
|
|
|
# get first page
|
|
expected_snapshots = mox_snapshots[:size]
|
|
res = self._test_snapshots_index_paginated(
|
|
marker=None, sort_dir="desc", snapshots=expected_snapshots,
|
|
url=base_url, has_more=True, has_prev=False)
|
|
snapshots = res.context['volume_snapshots_table'].data
|
|
self.assertItemsEqual(snapshots, expected_snapshots)
|
|
|
|
# get second page
|
|
expected_snapshots = mox_snapshots[size:2 * size]
|
|
marker = expected_snapshots[0].id
|
|
|
|
url = "&".join([base_url, "=".join([next, marker])])
|
|
res = self._test_snapshots_index_paginated(
|
|
marker=marker, sort_dir="desc", snapshots=expected_snapshots,
|
|
url=url, has_more=True, has_prev=True)
|
|
snapshots = res.context['volume_snapshots_table'].data
|
|
self.assertItemsEqual(snapshots, expected_snapshots)
|
|
|
|
# get last page
|
|
expected_snapshots = mox_snapshots[-size:]
|
|
marker = expected_snapshots[0].id
|
|
url = "&".join([base_url, "=".join([next, marker])])
|
|
res = self._test_snapshots_index_paginated(
|
|
marker=marker, sort_dir="desc", snapshots=expected_snapshots,
|
|
url=url, has_more=False, has_prev=True)
|
|
snapshots = res.context['volume_snapshots_table'].data
|
|
self.assertItemsEqual(snapshots, expected_snapshots)
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=1)
|
|
def test_snapshots_index_paginated_prev_page(self):
|
|
mox_snapshots = self.cinder_volume_snapshots.list()
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
base_url = reverse('horizon:project:volumes:snapshots_tab')
|
|
prev = snapshot_tables.VolumeSnapshotsTable._meta.prev_pagination_param
|
|
|
|
# prev from some page
|
|
expected_snapshots = mox_snapshots[size:2 * size]
|
|
marker = expected_snapshots[0].id
|
|
url = "&".join([base_url, "=".join([prev, marker])])
|
|
res = self._test_snapshots_index_paginated(
|
|
marker=marker, sort_dir="asc", snapshots=expected_snapshots,
|
|
url=url, has_more=True, has_prev=True)
|
|
snapshots = res.context['volume_snapshots_table'].data
|
|
self.assertItemsEqual(snapshots, expected_snapshots)
|
|
|
|
# back to first page
|
|
expected_snapshots = mox_snapshots[:size]
|
|
marker = expected_snapshots[0].id
|
|
url = "&".join([base_url, "=".join([prev, marker])])
|
|
res = self._test_snapshots_index_paginated(
|
|
marker=marker, sort_dir="asc", snapshots=expected_snapshots,
|
|
url=url, has_more=True, has_prev=False)
|
|
snapshots = res.context['volume_snapshots_table'].data
|
|
self.assertItemsEqual(snapshots, expected_snapshots)
|
|
|
|
@test.create_stubs({api.cinder: ('tenant_absolute_limits',
|
|
'volume_backup_list_paged',
|
|
'volume_list',
|
|
'volume_backup_supported',
|
|
),
|
|
api.nova: ('server_list',)})
|
|
def _test_backups_index_paginated(self, marker, sort_dir, backups, url,
|
|
has_more, has_prev):
|
|
backup_supported = True
|
|
|
|
api.cinder.volume_backup_supported(IsA(http.HttpRequest)).\
|
|
MultipleTimes().AndReturn(backup_supported)
|
|
api.cinder.volume_backup_list_paged(
|
|
IsA(http.HttpRequest), marker=marker, sort_dir=sort_dir,
|
|
paginate=True).AndReturn([backups, has_more, has_prev])
|
|
api.cinder.volume_list(IsA(http.HttpRequest)).AndReturn(
|
|
self.cinder_volumes.list())
|
|
self.mox.ReplayAll()
|
|
|
|
res = self.client.get(url)
|
|
self.assertEqual(res.status_code, 200)
|
|
self.assertTemplateUsed(res, 'project/volumes/index.html')
|
|
|
|
self.mox.UnsetStubs()
|
|
return res
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=1)
|
|
def test_backups_index_paginated(self):
|
|
mox_backups = self.cinder_volume_backups.list()
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
base_url = reverse('horizon:project:volumes:backups_tab')
|
|
next = backup_tables.BackupsTable._meta.pagination_param
|
|
|
|
# get first page
|
|
expected_backups = mox_backups[:size]
|
|
res = self._test_backups_index_paginated(
|
|
marker=None, sort_dir="desc", backups=expected_backups,
|
|
url=base_url, has_more=True, has_prev=False)
|
|
backups = res.context['volume_backups_table'].data
|
|
self.assertItemsEqual(backups, expected_backups)
|
|
|
|
# get second page
|
|
expected_backups = mox_backups[size:2 * size]
|
|
marker = expected_backups[0].id
|
|
|
|
url = "&".join([base_url, "=".join([next, marker])])
|
|
res = self._test_backups_index_paginated(
|
|
marker=marker, sort_dir="desc", backups=expected_backups, url=url,
|
|
has_more=True, has_prev=True)
|
|
backups = res.context['volume_backups_table'].data
|
|
self.assertItemsEqual(backups, expected_backups)
|
|
|
|
# get last page
|
|
expected_backups = mox_backups[-size:]
|
|
marker = expected_backups[0].id
|
|
url = "&".join([base_url, "=".join([next, marker])])
|
|
res = self._test_backups_index_paginated(
|
|
marker=marker, sort_dir="desc", backups=expected_backups, url=url,
|
|
has_more=False, has_prev=True)
|
|
backups = res.context['volume_backups_table'].data
|
|
self.assertItemsEqual(backups, expected_backups)
|
|
|
|
@override_settings(API_RESULT_PAGE_SIZE=1)
|
|
def test_backups_index_paginated_prev_page(self):
|
|
mox_backups = self.cinder_volume_backups.list()
|
|
size = settings.API_RESULT_PAGE_SIZE
|
|
base_url = reverse('horizon:project:volumes:backups_tab')
|
|
prev = backup_tables.BackupsTable._meta.prev_pagination_param
|
|
|
|
# prev from some page
|
|
expected_backups = mox_backups[size:2 * size]
|
|
marker = expected_backups[0].id
|
|
url = "&".join([base_url, "=".join([prev, marker])])
|
|
res = self._test_backups_index_paginated(
|
|
marker=marker, sort_dir="asc", backups=expected_backups, url=url,
|
|
has_more=True, has_prev=True)
|
|
backups = res.context['volume_backups_table'].data
|
|
self.assertItemsEqual(backups, expected_backups)
|
|
|
|
# back to first page
|
|
expected_backups = mox_backups[:size]
|
|
marker = expected_backups[0].id
|
|
url = "&".join([base_url, "=".join([prev, marker])])
|
|
res = self._test_backups_index_paginated(
|
|
marker=marker, sort_dir="asc", backups=expected_backups, url=url,
|
|
has_more=True, has_prev=False)
|
|
backups = res.context['volume_backups_table'].data
|
|
self.assertItemsEqual(backups, expected_backups)
|