openstack/ironic-inspector
Code Issues Proposed changes

Merge "Allow operators to disable clean_up sync"

Browse Source
This commit is contained in:
Zuul 2020-06-30 12:42:03 +00:00 committed by Gerrit Code Review
commit a78df4b827
3 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic_inspector/conductor/manager.py
View File

@ -81,11 +81,13 @@ class ConductorManager(object):
driver.init_filter()
periodic_clean_up_ = periodics.periodic(
spacing=CONF.clean_up_period
spacing=CONF.clean_up_period,
enabled=(CONF.clean_up_period != 0)
)(periodic_clean_up)
sync_with_ironic_ = periodics.periodic(
spacing=CONF.clean_up_period
spacing=CONF.clean_up_period,
enabled=(CONF.clean_up_period != 0)
)(sync_with_ironic)
callables = [(periodic_clean_up_, None, None),

11
ironic_inspector/conf/default.py
View File

@ -55,8 +55,15 @@ _OPTS = [
'failed, set to 0 to disable.')),
cfg.IntOpt('clean_up_period',
default=60,
min=0,
help=_('Amount of time in seconds, after which repeat clean up '
'of timed out nodes and old nodes status information.')),
'of timed out nodes and old nodes status information. '
'WARNING: If set to a value of 0, then the periodic '
'task is disabled and inspector will not sync with '
'ironic to complete the internal clean-up process. '
'Not advisable if the deployment uses a PXE filter, '
'and will result in the ironic-inspector ceasing '
'periodic cleanup activities.')),
cfg.BoolOpt('use_ssl',
default=False,
help=_('SSL Enabled/Disabled')),
@ -89,7 +96,7 @@ _OPTS = [
'endpoint via multicast DNS.')),
cfg.BoolOpt('standalone', default=True,
help=_('Whether to run ironic-inspector as a standalone '
'service. It\'s EXPERIMENTAL to set to False.'))
'service. It\'s EXPERIMENTAL to set to False.')),
]

8
releasenotes/notes/ability-to-turn-off-periodic-sync-5309ff2aa8a9ec14.yaml Normal file
View File

@ -0,0 +1,8 @@
---
features:
- |
Adds the ability for periodic clean-up and synchronization tasks with
``ironic`` to be able to be disabled by setting the
``[DEFAULT]clean_up_period`` to a value of ``0``. This is intended for
"stand-alone" operators only as it may result in unexpected behaviors if
used in a non-standalone environment.