openstack/ironic-python-agent
Code Issues Proposed changes

fix multipathd error handling release notes

Browse Source 
This commit:
  - fixes some "multipathd error handling improvement"
    release notes
  - fixes a related comment in the code

Related launchpad issue https://bugs.launchpad.net/ironic-python-agent/+bug/2031092

Change-Id: Ie3ba0601fa117b053cb8db6284e47249ca9c9134
Signed-off-by: Adam Rozman <adam.rozman@est.tech>
This commit is contained in:
Adam Rozman 2023-11-10 09:50:22 +02:00
parent 845df338f8
commit 7a52314695
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ironic_python_agent/hardware.py
View File

@ -216,7 +216,8 @@ def _enable_multipath():
# NOTE(rozzix): This could cause an OS error:
# "process is already running failed to create pid file" depending on
# the multipathd version in case multipathd is already running.
# I suggest muting the OS error in addition to the execution error.
# The safest way to start multipathd is to expect OS error in addition
# to the execution error and handle both as inconsequential.
il_utils.try_execute('multipathd')
# This is mainly to get the system to actually do the needful and
# identify/enumerate paths by combining what it can detect and what

25
releasenotes/notes/multipath_error_handling_improvement-1669d0de4bfdbe95.yaml
View File

@ -1,20 +1,19 @@
---
fixes:
- |
The error handling of the multipathd service startup/discovery process.
Fixes the error handling of multipathd service startup/discovery process.
IPA handles both scenario when the multipathd service is already started
and the scenario when the service has not been started and in the second
scenario IPA will try to start the service. IPA is not pre checking whether
multipathd is running already or not, it will start the multipathd service
even if it is already running and expects 0 error code . It has been
noticed that with certain combinations of Linux distros and multipathd
versions the error code is not 0 when IPA tries to start multipathd in
case an instance of multipathd is already running.
When the expected return code is not 0 an exception will be thrown and that
scenario IPA will try to start the service. IPA is not checking whether
multipathd is running already and not, it will start the multipathd service
even it is already running and expects 0 error code even if the service
is already running. It has been noticed that with certain combinations of
distros and multipathd versions the error code is not 0 when IPA tries
to start multipathd when an instance of multipathd is already running.
When the expected return code is not 0 that causes an exception and that
will cause the multipath device discovery to terminate prematurely and
if the selected root device is a multipath device then IPA won't be
able to provision.
This fix discards the exception that is caused by the non 0 error code
returned by the multipathd startup process. In case there is a genuine
issue with the multipath service, that would be caught when the actual
multipath device listing command is executed (multipath -ll).
able to provision. This fix discards the exception that is caused by the
non 0 error code returned by the multipathd startup process. In case there
is a genuine issue with the multipath service, that would be caught when
the actual multipath device listing command is executed (multipath -ll).