openstack/ironic-python-agent
Code Issues Proposed changes

Rescan after restarting the md device

Browse Source 
If an md device is restarted, there is a chance, depending
on the OS, that the partition may not be found upon start
of the md device.

Instead, we should always rescan after re-assembling the raid
device.

Story: 2007275
Task: 38712
Change-Id: I92bac20812940e04381a54ef2905ef5f6e293813
This commit is contained in:
Julia Kreger 2020-02-07 14:39:29 -08:00
parent 55b011cb1f
commit 916cd5c8de
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ironic_python_agent/extensions/image.py
View File

@ -351,15 +351,26 @@ def _install_grub2(device, root_uuid, efi_system_part_uuid=None,
prep_boot_part_uuid=None): prep_boot_part_uuid=None):
"""Install GRUB2 bootloader on a given device.""" """Install GRUB2 bootloader on a given device."""
LOG.debug("Installing GRUB2 bootloader on device %s", device) LOG.debug("Installing GRUB2 bootloader on device %s", device)
root_partition = _get_partition(device, uuid=root_uuid)
efi_partition = None efi_partition = None
efi_partition_mount_point = None efi_partition_mount_point = None
efi_mounted = False efi_mounted = False
# NOTE(TheJulia): Seems we need to get this before ever possibly
# restart the device in the case of multi-device RAID as pyudev
# doesn't exactly like the partition disappearing.
root_partition = _get_partition(device, uuid=root_uuid)
# If the root device is an md device (or partition), restart the device
# (to help grub finding it) and identify the underlying holder disks
# to install grub.
if hardware.is_md_device(device): if hardware.is_md_device(device):
# If the root device is an md device (or partition), # If the root device is an md device (or partition),
# restart the device to help grub find it later on. # restart the device to help grub find it later on.
hardware.md_restart(device) hardware.md_restart(device)
# If an md device, we need to rescan the devices anyway to pickup
# the md device partition.
_rescan_device(device)
elif (_is_bootloader_loaded(device) elif (_is_bootloader_loaded(device)
and not (efi_system_part_uuid and not (efi_system_part_uuid
or prep_boot_part_uuid)): or prep_boot_part_uuid)):

5
releasenotes/notes/md-restart-9e0d47863a086792.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Rescans partitions on a software RAID device that gets restarted when
installing boot loader.