openstack/ironic-python-agent
Code Issues Proposed changes

Use oslo_config.fixture in unit tests

Browse Source 
It provides cleaner per-tests config objects, with more options to
configure the fixture.

Also, allow overriding config fixture in particular test cases if
needed.

Change-Id: I2e9945b6168d97d7ee861924ac2f4ca5cd03dde2
This commit is contained in:
Vasyl Saienko 2017-11-09 16:58:50 +02:00
parent c951ef2c10
commit c4f10dce13
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ironic_python_agent/tests/unit/base.py
View File

@ -20,10 +20,14 @@ import subprocess
import ironic_lib import ironic_lib
import mock import mock
from oslo_concurrency import processutils from oslo_concurrency import processutils
from oslo_config import cfg
from oslo_config import fixture as config_fixture
from oslotest import base as test_base from oslotest import base as test_base
from ironic_python_agent import utils from ironic_python_agent import utils
CONF = cfg.CONF
class IronicAgentTest(test_base.BaseTestCase): class IronicAgentTest(test_base.BaseTestCase):
"""Extends the base test to provide common features across agent tests.""" """Extends the base test to provide common features across agent tests."""
@ -40,6 +44,7 @@ class IronicAgentTest(test_base.BaseTestCase):
If the mock is called, an exception is raised to warn the tester. If the mock is called, an exception is raised to warn the tester.
""" """
self._set_config()
# NOTE(bigjools): Not using a decorator on tests because I don't # NOTE(bigjools): Not using a decorator on tests because I don't
# want to force every test method to accept a new arg. Instead, they # want to force every test method to accept a new arg. Instead, they
# can override or examine this self._exec_patch Mock as needed. # can override or examine this self._exec_patch Mock as needed.
@ -58,3 +63,16 @@ class IronicAgentTest(test_base.BaseTestCase):
self.patch(subprocess, 'check_call', self._exec_patch) self.patch(subprocess, 'check_call', self._exec_patch)
self.patch(subprocess, 'check_output', self._exec_patch) self.patch(subprocess, 'check_output', self._exec_patch)
self.patch(utils, 'execute', self._exec_patch) self.patch(utils, 'execute', self._exec_patch)
def _set_config(self):
self.cfg_fixture = self.useFixture(config_fixture.Config(CONF))
def config(self, **kw):
"""Override config options for a test."""
self.cfg_fixture.config(**kw)
def set_defaults(self, **kw):
"""Set default values of config options."""
group = kw.pop('group', None)
for o, v in kw.items():
self.cfg_fixture.set_default(o, v, group=group)