From 438c69af7c6ce8f33ab64cff2f470ac0cd35ef30 Mon Sep 17 00:00:00 2001
From: Edan David <edand@mellanox.com>
Date: Sun, 19 Jun 2016 05:52:11 -0400
Subject: [PATCH] Removes the use of mutables as default args
Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None, 'arg = [] if arg is None else arg'.
TrivialFix
Change-Id: I384b24e81543999a8b873e3223cd409ed799ffa0
---
ironic_python_agent/tests/unit/test_api.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ironic_python_agent/tests/unit/test_api.py b/ironic_python_agent/tests/unit/test_api.py
index 846d0c36d..39f2cecfc 100644
--- a/ironic_python_agent/tests/unit/test_api.py
+++ b/ironic_python_agent/tests/unit/test_api.py
@@ -118,7 +118,8 @@ class TestIronicAPI(test_base.BaseTestCase):
status=status, method="post")
def get_json(self, path, expect_errors=False, headers=None,
- extra_environ=None, q=[], path_prefix=PATH_PREFIX, **params):
+ extra_environ=None, q=None, path_prefix=PATH_PREFIX,
+ **params):
"""Sends simulated HTTP GET request to Pecan test app.
:param path: url path of target service
@@ -137,6 +138,7 @@ class TestIronicAPI(test_base.BaseTestCase):
'q.value': [],
'q.op': [],
}
+ q = [] if q is None else q
for query in q:
for name in ['field', 'op', 'value']:
query_params['q.%s' % name].append(query.get(name, ''))