openstack/ironic-ui
Code Issues Proposed changes

Normalize operation messages into capital case

Browse Source 
Operation messages use sentence case in html files
(e.g. 'Create port') while capital case in js files
(e.g. 'Create Port'). Normalize them to use capital case in order
not to generate different translation items for same message.

Change-Id: I1a40859447eb6ba53eef19521e110f786380a00b
This commit is contained in:
francotseng 2019-04-03 14:34:48 +08:00
parent 929622786e
commit a6a784c4a3
3 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ironic_ui/static/dashboard/admin/ironic/node-details/node-details.html
View File

@ -34,7 +34,7 @@
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ ctrl.node.maintenance ? <span>{$ ctrl.node.maintenance ?
"Maintenance off" : "Maintenance on" | translate $}</span> "Maintenance Off" : "Maintenance On" | translate $}</span>
</a> </a>
</li> </li>
<li role="presentation"> <li role="presentation">
@ -42,7 +42,7 @@
ng-click="ctrl.bootDeviceService.setBootDevice(ctrl.node); ng-click="ctrl.bootDeviceService.setBootDevice(ctrl.node);
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ "Set boot device" | translate $}</span> <span>{$ "Set Boot Device" | translate $}</span>
</a> </a>
</li> </li>
<li role="presentation"> <li role="presentation">
@ -50,7 +50,7 @@
ng-click="ctrl.raidConfigService.setRaidConfig(ctrl.node); ng-click="ctrl.raidConfigService.setRaidConfig(ctrl.node);
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ "Set RAID configuration" | translate $}</span> <span>{$ "Set RAID Configuration" | translate $}</span>
</a> </a>
</li> </li>
<li role="presentation" <li role="presentation"
@ -68,7 +68,7 @@
disabled="isDefined(ctrl.nodeValidationMap.console) disabled="isDefined(ctrl.nodeValidationMap.console)
&& ctrl.nodeValidationMap.console.result===false" && ctrl.nodeValidationMap.console.result===false"
callback="ctrl.toggleConsoleMode"> callback="ctrl.toggleConsoleMode">
{$ ctrl.node.console_enabled ? 'Disable console' : 'Enable console' | translate $} {$ ctrl.node.console_enabled ? 'Disable Console' : 'Enable Console' | translate $}
</action> </action>
<li role="presentation"> <li role="presentation">
<a role="menuitem" <a role="menuitem"

16
ironic_ui/static/dashboard/admin/ironic/node-details/sections/configuration.html
View File

@ -33,7 +33,7 @@
<action button-type="split-button" <action button-type="split-button"
action-classes="'btn btn-default btn-sm'" action-classes="'btn btn-default btn-sm'"
callback="ctrl.createPort"> callback="ctrl.createPort">
{$ ::'Create port' | translate $} {$ ::'Create Port' | translate $}
</action> </action>
<menu> <menu>
<action button-type="menu-item" <action button-type="menu-item"
@ -41,7 +41,7 @@
item="tCtrl.selected" item="tCtrl.selected"
disabled="tCtrl.selected.length === 0"> disabled="tCtrl.selected.length === 0">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
{$ ::'Delete ports' | translate $} {$ ::'Delete Ports' | translate $}
</action> </action>
</menu> </menu>
</action-list> </action-list>
@ -93,7 +93,7 @@
action-classes="'btn btn-default btn-sm'" action-classes="'btn btn-default btn-sm'"
callback="ctrl.editPort" callback="ctrl.editPort"
item="port"> item="port">
{$ ::'Edit port' | translate $} {$ ::'Edit Port' | translate $}
</action> </action>
<menu> <menu>
<li role="presentation"> <li role="presentation">
@ -102,7 +102,7 @@
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
<span>{$ :: 'Delete port' | translate $}</span> <span>{$ ::'Delete Port' | translate $}</span>
</a> </a>
</li> </li>
</menu> </menu>
@ -139,7 +139,7 @@
<action button-type="split-button" <action button-type="split-button"
action-classes="'btn btn-default btn-sm'" action-classes="'btn btn-default btn-sm'"
callback="ctrl.createPortgroup"> callback="ctrl.createPortgroup">
{$ ::'Create portgroup' | translate $} {$ ::'Create Portgroup' | translate $}
</action> </action>
<menu> <menu>
<action button-type="menu-item" <action button-type="menu-item"
@ -147,7 +147,7 @@
item="tCtrl.selected" item="tCtrl.selected"
disabled="tCtrl.selected.length === 0"> disabled="tCtrl.selected.length === 0">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
{$ ::'Delete portgroups' | translate $} {$ ::'Delete Portgroups' | translate $}
</action> </action>
</menu> </menu>
</action-list> </action-list>
@ -206,7 +206,7 @@
action-classes="'btn btn-default btn-sm'" action-classes="'btn btn-default btn-sm'"
callback="ctrl.editPortgroup" callback="ctrl.editPortgroup"
item="portgroup"> item="portgroup">
{$ ::'Edit portgroup' | translate $} {$ ::'Edit Portgroup' | translate $}
</action> </action>
<menu> <menu>
<li role="presentation" <li role="presentation"
@ -217,7 +217,7 @@
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
<span>{$ :: 'Delete portgroup' | translate $}</span> <span>{$ ::'Delete Portgroup' | translate $}</span>
</a> </a>
</li> </li>
</menu> </menu>

12
ironic_ui/static/dashboard/admin/ironic/node-list/node-list.html
View File

@ -33,7 +33,7 @@
item="tCtrl.selected" item="tCtrl.selected"
disabled="tCtrl.selected.length === 0"> disabled="tCtrl.selected.length === 0">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
{$ ::'Delete nodes' | translate $} {$ ::'Delete Nodes' | translate $}
</action> </action>
<menu> <menu>
<li role="presentation" <li role="presentation"
@ -58,7 +58,7 @@
mode); mode);
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ mode ? 'Maintenance on' : 'Maintenance off' | translate $}</span> <span>{$ mode ? 'Maintenance On' : 'Maintenance Off' | translate $}</span>
</a> </a>
</li> </li>
</menu> </menu>
@ -160,7 +160,7 @@
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ node.maintenance ? <span>{$ node.maintenance ?
"Maintenance off" : "Maintenance on" | translate $}</span> "Maintenance Off" : "Maintenance On" | translate $}</span>
</a> </a>
</li> </li>
<li role="presentation"> <li role="presentation">
@ -168,7 +168,7 @@
ng-click="table.bootDeviceService.setBootDevice(node); ng-click="table.bootDeviceService.setBootDevice(node);
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span>{$ "Set boot device" | translate $}</span> <span>{$ "Set Boot Device" | translate $}</span>
</a> </a>
</li> </li>
<li role="presentation" <li role="presentation"
@ -182,13 +182,13 @@
$event.stopPropagation(); $event.stopPropagation();
$event.preventDefault()"> $event.preventDefault()">
<span class="fa fa-trash"></span> <span class="fa fa-trash"></span>
{$ ::'Delete node' | translate $} {$ ::'Delete Node' | translate $}
</a> </a>
</li> </li>
<action button-type="menu-item" <action button-type="menu-item"
callback="table.createPort" callback="table.createPort"
item="node"> item="node">
{$ ::'Create port' | translate $} {$ ::'Create Port' | translate $}
</action> </action>
<li role="presentation" <li role="presentation"
ng-repeat="transition in table.getNodeStateTransitions(node)"> ng-repeat="transition in table.getNodeStateTransitions(node)">