openstack/ironic
Code Issues Proposed changes

Add additional logging on iLO power failure

Browse Source 
Currently, there's no information printed about the style of failure
when we cannot properly change the power status on an iLO server. Now,
we ensure the actual server state and the expected server state at the
BMC level is logged, helping with troubleshooting edge cases.

Related-bug: 2021995
Change-Id: I77dc69ef4dd42e5ad674f5c00a4500027ef030ec
This commit is contained in:
Jay Faulkner 2023-06-07 13:24:55 -07:00
parent 54da324900
commit 1335402f42
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic/drivers/modules/ilo/power.py
View File

@ -174,9 +174,12 @@ def _wait_for_state_change(node, target_state, requested_state,
else:
timeout = int(max_retry * interval)
LOG.error("iLO failed to change state to %(tstate)s "
"within %(timeout)s sec for node %(node)s",
"within %(timeout)s sec for node %(node)s. Reported "
"state from iLO is %(state)s, expected state from iLO "
"is %(expected)s.",
{'tstate': target_state, 'node': node.uuid,
'timeout': int(max_retry * interval)})
'timeout': int(max_retry * interval), 'state': state[0],
'expected': state_to_check})
raise exception.PowerStateFailure(pstate=target_state)