openstack/ironic
Code Issues Proposed changes

Remove the xclarity deprecation

Browse Source 
The lenovo team has setup third party CI which is reporting
into gerrit the job status. While their CI is still early in
the tests it executes, the log they provided to demonstrates
that they were able add a node to be managed via xclarity
and obtain the current boot devices.

They are diligently working on making logging available,
and as I understand it they will soon be running a deployment
scenario.

As such, I'm confident that we can go ahead and remove the
deprecation notice and flags.

Change-Id: I556c7ab42a74ebaa1f65642f2f18d23885de5ce3
Story: 2003097
Task: 27648
This commit is contained in:
Julia Kreger 2018-10-24 13:01:17 -07:00
parent 7cf2d18fa5
commit 1a4fdc4b05
4 changed files with 10 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ironic/drivers/modules/xclarity/management.py
View File

@ -48,15 +48,6 @@ SUPPORTED_BOOT_DEVICES = [
class XClarityManagement(base.ManagementInterface):
# NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this
# interface was not established before Rocky cycle feature freeze.
# Lenovo is continuing to work on establishing their Third Party CI,
# and upon establishment and verification of Thid Party CI, this
# unsupported flag shall be removed.
# TODO(TheJulia): If Third Party CI is not online prior to the
# Stein Feature Freeze, this interface should be removed.
supported = False
def get_properties(self):
return common.COMMON_PROPERTIES

9
ironic/drivers/modules/xclarity/power.py
View File

@ -32,15 +32,6 @@ xclarity_client_exceptions = importutils.try_import(
class XClarityPower(base.PowerInterface):
# NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this
# interface was not established before Rocky cycle feature freeze.
# Lenovo is continuing to work on establishing their Third Party CI,
# and upon establishment and verification of Thid Party CI, this
# unsupported flag shall be removed.
# TODO(TheJulia): If Third Party CI is not online prior to the
# Stein Feature Freeze, this interface should be removed.
supported = False
def get_properties(self):
return common.get_properties()

9
ironic/drivers/xclarity.py
View File

@ -24,15 +24,6 @@ from ironic.drivers.modules.xclarity import power
class XClarityHardware(generic.GenericHardware):
"""XClarity hardware type. """
# NOTE(TheJulia): Marking as unsupported as 3rd Party CI for this
# hardware type was not established before Rocky cycle feature freeze.
# Lenovo is continuing to work on establishing their Third Party CI,
# and upon establishment and verification of Thid Party CI, this
# unsupported flag shall be removed.
# TODO(TheJulia): If Third Party CI is not online prior to the
# Stein Feature Freeze, this hardware type should be removed.
supported = False
@property
def supported_management_interfaces(self):
"""List of supported management interfaces."""

10
releasenotes/notes/undeprecate-xclarity-4f4752017e8310e7.yaml Normal file
View File

@ -0,0 +1,10 @@
---
deprecations:
- |
The ``xclarity`` hardware type, which was previously deprecated, is no
longer deprecated. Lenovo has instituted third-party CI which is a
requirement for a driver to remain in-tree.
other:
- |
The ``xclarity`` hardware type is no longer deprecated as Lenovo
has implemented third-party CI to enable testing.