openstack/ironic
Code Issues Proposed changes

devstack: Don't modprobe inside containers

Browse Source 
When running in a container, the host must already have the modules
inserted in its kernel.

Change-Id: Ic61ad57557be5dd1319db70bfb50c23836874028
This commit is contained in:
Julian Edwards 2017-03-16 09:56:50 +10:00
parent 82a4b288ba
commit 1de3681b13
1 changed files with 13 additions and 2 deletions

15
devstack/lib/ironic

@ -1662,10 +1662,21 @@ function enroll_nodes {
fi
}
function die_if_module_not_loaded {
if ! grep -q $1 /proc/modules; then
die $LINENO "$1 kernel module is not loaded"
fi
}
function configure_iptables {
# enable tftp natting for allowing connections to HOST_IP's tftp server
sudo modprobe nf_conntrack_tftp
sudo modprobe nf_nat_tftp
if ! running_in_container; then
sudo modprobe nf_conntrack_tftp
sudo modprobe nf_nat_tftp
else
die_if_module_not_loaded nf_conntrack_tftp
die_if_module_not_loaded nf_nat_tftp
fi
# explicitly allow DHCP - packets are occasionally being dropped here
sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true
# nodes boot from TFTP and callback to the API server listening on $HOST_IP