openstack/ironic
Code Issues Proposed changes

Merge "Fix incorrect ibmc_address parsing on Python 3.8"

Browse Source
This commit is contained in:
Zuul 2020-01-20 23:06:54 +00:00 committed by Gerrit Code Review
commit 443e0b1093
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ironic/drivers/modules/ibmc/utils.py
View File

@ -77,11 +77,10 @@ def parse_driver_info(node):
# Validate the iBMC address # Validate the iBMC address
address = driver_info['ibmc_address'] address = driver_info['ibmc_address']
parsed = netutils.urlsplit(address) if '://' not in address:
if not parsed.scheme:
address = 'https://%s' % address address = 'https://%s' % address
parsed = netutils.urlsplit(address)
parsed = netutils.urlsplit(address)
if not parsed.netloc: if not parsed.netloc:
raise exception.InvalidParameterValue( raise exception.InvalidParameterValue(
_('Invalid iBMC address %(address)s set in ' _('Invalid iBMC address %(address)s set in '

5
releasenotes/notes/ibmc-38-169438974508f62e.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fixes incorrect parsing of ``ibmc_address`` with a port but without
a schema in the ``ibmc`` hardware type on Python 3.8.