From 45020712d73a2040bd91b74bb2d1df9b55233ba6 Mon Sep 17 00:00:00 2001 From: Ilya Etingof Date: Tue, 14 May 2019 15:21:05 +0200 Subject: [PATCH] Fix binary file upload to Swift Fixes binary files upload to Swift. Prior to this fix, binary file upload to Swift might fail at unicode characters interpretation. Story: 2005697 Change-Id: Icbe69bc628af8bdfd48327319f5c6b01607700bf --- ironic/common/swift.py | 2 +- .../notes/fix-swift-binary-upload-bf9471fca29290e1.yaml | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-swift-binary-upload-bf9471fca29290e1.yaml diff --git a/ironic/common/swift.py b/ironic/common/swift.py index 2a0a061dc5..d485ff45cc 100644 --- a/ironic/common/swift.py +++ b/ironic/common/swift.py @@ -97,7 +97,7 @@ class SwiftAPI(object): operation = _("put container") raise exception.SwiftOperationError(operation=operation, error=e) - with open(filename, "r") as fileobj: + with open(filename, "rb") as fileobj: try: obj_uuid = self.connection.put_object(container, diff --git a/releasenotes/notes/fix-swift-binary-upload-bf9471fca29290e1.yaml b/releasenotes/notes/fix-swift-binary-upload-bf9471fca29290e1.yaml new file mode 100644 index 0000000000..14d4926db1 --- /dev/null +++ b/releasenotes/notes/fix-swift-binary-upload-bf9471fca29290e1.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fixes binary files upload to Swift. Prior to this fix, binary file + upload to Swift might fail at unicode characters interpretation.