openstack/ironic
Code Issues Proposed changes

Remove WARNING from pin_release_version's help

Browse Source 
Rolling upgrades works so this removes the warning from the
help for the [default]/pin_release_version config option.

Change-Id: I0ba440a4136267e676370377394cee534505fdcd
Partial-Bug: #1502887
This commit is contained in:
Ruby Loo 2017-08-02 21:31:24 -04:00
parent 3e131587ea
commit 4686955d25
2 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
etc/ironic/ironic.conf.sample
View File

@ -360,14 +360,13 @@
# value) # value)
#host = localhost #host = localhost
# WARNING: This configuration option is part of the incomplete # Used for rolling upgrades. Setting this option downgrades
# rolling upgrades work. Do not change this from the default # (or pins) the internal ironic RPC communication and database
# value. Used for rolling upgrades. Setting this option # objects to their respective versions, so they are compatible
# downgrades (or pins) the internal ironic RPC communication # with older services. When doing a rolling upgrade from
# to the specified version to enable communication with older # version N to version N+1, set (to pin) this to N. To unpin
# services. When doing a rolling upgrade from version X to # (default), leave it unset and the latest versions of RPC
# version Y, set (pin) this to X. To unpin, leave it unset. # communication and database objects will be used. (string
# Defaults to using the newest possible RPC behavior. (string
# value) # value)
# Allowed values: ocata, 8.0, 7.0 # Allowed values: ocata, 8.0, 7.0
#pin_release_version = <None> #pin_release_version = <None>

16
ironic/conf/default.py
View File

@ -271,16 +271,14 @@ service_opts = [
cfg.StrOpt('pin_release_version', cfg.StrOpt('pin_release_version',
choices=versions.RELEASE_VERSIONS, choices=versions.RELEASE_VERSIONS,
# TODO(xek): mutable=True, # TODO(xek): mutable=True,
help=_('WARNING: This configuration option is part of the ' help=_('Used for rolling upgrades. Setting this option '
'incomplete rolling upgrades work. Do not change this '
'from the default value. '
'Used for rolling upgrades. Setting this option '
'downgrades (or pins) the internal ironic RPC ' 'downgrades (or pins) the internal ironic RPC '
'communication to the specified version to enable ' 'communication and database objects to their respective '
'communication with older services. When doing a ' 'versions, so they are compatible with older services. '
'rolling upgrade from version X to version Y, set (pin) ' 'When doing a rolling upgrade from version N to version '
'this to X. To unpin, leave it unset. Defaults to ' 'N+1, set (to pin) this to N. To unpin (default), leave '
'using the newest possible RPC behavior.')), 'it unset and the latest versions of RPC communication '
'and database objects will be used.')),
] ]
utils_opts = [ utils_opts = [