openstack/ironic
Code Issues Proposed changes

Fix syntax errors in the shell scripts under devstack/tools

Browse Source 
This patch is fixing the syntax errors/warnings in the shell scripts
under devstack/tools and add that directory to the tox bashate command.

Change-Id: I957a88f5b7009fe92078eb3d53e225943d28a539
Partial-Bug: #1526518
This commit is contained in:
Lucas Alvares Gomes 2015-12-15 20:12:01 +00:00 committed by Jim Rollenhagen
parent 2a5f6ded69
commit 49e273b1a5
3 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
devstack/tools/ironic/scripts/create-node
View File

@ -72,7 +72,6 @@ if ! virsh list --all | grep -q $NAME; then
--bootdev network --name $NAME --image "$volume_path" \ --bootdev network --name $NAME --image "$volume_path" \
--arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \ --arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \
--emulator $EMULATOR --network $BRIDGE $VM_LOGGING >&2 --emulator $EMULATOR --network $BRIDGE $VM_LOGGING >&2
fi fi
# echo mac # echo mac

5
tox.ini
View File

@ -66,7 +66,6 @@ commands = {posargs}
deps = deps =
{env:BASHATE_INSTALL_PATH:bashate==0.3.2} {env:BASHATE_INSTALL_PATH:bashate==0.3.2}
whitelist_externals = bash whitelist_externals = bash
# TODO(lucasagomes): Check the tools/ directory as well
commands = bash -c "find {toxinidir}/devstack \ commands = bash -c "find {toxinidir}/devstack \
-not \( -type d -name .?\* -prune \) \ # prune all 'dot' dirs -not \( -type d -name .?\* -prune \) \ # prune all 'dot' dirs
-type f \ # only files -type f \ # only files
@ -74,9 +73,11 @@ commands = bash -c "find {toxinidir}/devstack \
-not -name \*~ \ # skip editor files -not -name \*~ \ # skip editor files
-not -name \*.xml \ # skip xml files -not -name \*.xml \ # skip xml files
-not -name \*.template \ # skip template files -not -name \*.template \ # skip template files
-not -wholename \*scripts/configure-vm \ # that's a python script
\( \ \( \
-name \*.sh -or \ # add files eding with .sh -name \*.sh -or \ # add files eding with .sh
-wholename \*/lib/\* \ # add files under lib/ -wholename \*/lib/\* -or \ # add files under lib/
-wholename \*/tools/\* \ # add files under tools/
\) \ \) \
-print0 | xargs -0 bashate -v -iE006 -eE005,E042" -print0 | xargs -0 bashate -v -iE006 -eE005,E042"