Fix syntax errors in the shell scripts under devstack/tools

This patch is fixing the syntax errors/warnings in the shell scripts
under devstack/tools and add that directory to the tox bashate command.

Change-Id: I957a88f5b7009fe92078eb3d53e225943d28a539
Partial-Bug: #1526518

devstack/tools/ironic/scripts/create-node

@@ -72,7 +72,6 @@ if ! virsh list --all | grep -q $NAME; then
         --bootdev network --name $NAME --image "$volume_path" \
         --arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \
         --emulator $EMULATOR --network $BRIDGE $VM_LOGGING >&2
-
 fi
 
 # echo mac

tox.ini

@@ -66,7 +66,6 @@ commands = {posargs}
 deps =
    {env:BASHATE_INSTALL_PATH:bashate==0.3.2}
 whitelist_externals = bash
-# TODO(lucasagomes): Check the tools/ directory as well
 commands = bash -c "find {toxinidir}/devstack    \
          -not \( -type d -name .?\* -prune \)    \ # prune all 'dot' dirs
          -type f                                 \ # only files
@@ -74,9 +73,11 @@ commands = bash -c "find {toxinidir}/devstack    \
          -not -name \*~                          \ # skip editor files
          -not -name \*.xml                       \ # skip xml files
          -not -name \*.template                  \ # skip template files
+         -not -wholename \*scripts/configure-vm  \ # that's a python script
          \(                                      \
           -name \*.sh -or                        \ # add files eding with .sh
-          -wholename \*/lib/\*                   \ # add files under lib/
+          -wholename \*/lib/\* -or               \ # add files under lib/
+          -wholename \*/tools/\*                 \ # add files under tools/
          \)                                      \
          -print0 | xargs -0 bashate -v -iE006 -eE005,E042"