openstack/ironic
Code Issues Proposed changes

Followup patch for security dashboard clean steps

Browse Source 
This patch addresses all the remaining comments on the
security dashboard clean steps for ilo driver.

Change-Id: Id454642439d09fa8edd7bab9259dfc4ba9b55a01
This commit is contained in:
ankit 2021-04-13 10:13:04 +00:00
parent b4d8a493d9
commit 5a27ea6fe6
3 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/source/admin/drivers/ilo.rst
View File

@ -1668,7 +1668,7 @@ manual cleaning step can only be initiated when a node is in the ``manageable``
state. Once the manual cleaning is finished, the node will be put in the state. Once the manual cleaning is finished, the node will be put in the
``manageable`` state again. A user can follow steps from :ref:`manual_cleaning` ``manageable`` state again. A user can follow steps from :ref:`manual_cleaning`
to initiate manual cleaning operation on a node. This feature is only supported to initiate manual cleaning operation on a node. This feature is only supported
for ``ilo5`` based hardware. for iLO5 based hardware.
An example of a manual clean step with ``security_parameters_update`` as the An example of a manual clean step with ``security_parameters_update`` as the
only clean step could be:: only clean step could be::
@ -1736,7 +1736,7 @@ Update Minimum Password Length security parameter as manual clean step
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
iLO driver can invoke ``Minimum Password Length`` security parameter update as a manual clean iLO driver can invoke ``Minimum Password Length`` security parameter update as a manual clean
step. This feature is only supported for ``ilo5`` based hardware. step. This feature is only supported for iLO5 based hardware.
An example of a manual clean step with ``update_minimum_password_length`` as the An example of a manual clean step with ``update_minimum_password_length`` as the
only clean step could be:: only clean step could be::
@ -1758,7 +1758,7 @@ Update Authentication Failure Logging security parameter as manual clean step
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
iLO driver can invoke ``Authentication Failure Logging`` security parameter update as a manual clean iLO driver can invoke ``Authentication Failure Logging`` security parameter update as a manual clean
step. This feature is only supported for ``ilo5`` based hardware. step. This feature is only supported for iLO5 based hardware.
An example of a manual clean step with ``Authentication Failure Logging`` as the An example of a manual clean step with ``Authentication Failure Logging`` as the
only clean step could be:: only clean step could be::

14
ironic/drivers/modules/ilo/management.py
View File

@ -108,9 +108,10 @@ _MINIMUM_PASSWORD_LENGTH_UPDATE_ARGSINFO = {
}, },
'ignore': { 'ignore': {
'description': ( 'description': (
"This argument represents boolean parameter. If set 'True' the " "This argument represents boolean parameter. If set 'True' "
"security parameters will be ignored. If not specified, default " "the security parameters will be ignored by iLO while "
"will be 'False'." "computing the overall iLO security status. If not specified, "
"default will be 'False'."
), ),
'required': False 'required': False
} }
@ -127,9 +128,10 @@ _Auth_Failure_Logging_Threshold_ARGSINFO = {
}, },
'ignore': { 'ignore': {
'description': ( 'description': (
"This argument represents boolean parameter. If set 'True' the " "This argument represents boolean parameter. If set 'True' "
"security parameters will be ignored. If not specified, default " "the security parameters will be ignored by iLO while "
"will be 'False'." "computing the overall iLO security status. If not specified, "
"default will be 'False'."
), ),
'required': False 'required': False
} }

2
releasenotes/notes/adding-security-param-clean-step-00d5548072a397f2.yaml
View File

@ -1,7 +1,7 @@
--- ---
features: features:
- | - |
Adding new clean steps to ``ilo`` hardware type - Adding new clean steps to ``ilo`` and ``ilo5`` hardware type -
``security_parameters_update``, ``update_minimum_password_length``, ``security_parameters_update``, ``update_minimum_password_length``,
and ``update_auth_failure_logging_threshold`` which allows users to and ``update_auth_failure_logging_threshold`` which allows users to
modify ilo system security settings. modify ilo system security settings.