openstack/ironic
Code Issues Proposed changes

Merge "Use property plus abstractmethod for abstractproperty"

Browse Source
This commit is contained in:
Zuul 2020-08-11 10:40:14 +00:00 committed by Gerrit Code Review
commit 84af06b199
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ironic/drivers/hardware_type.py
View File

@ -42,19 +42,23 @@ class AbstractHardwareType(object, metaclass=abc.ABCMeta):
# Required hardware interfaces # Required hardware interfaces
@abc.abstractproperty @property
@abc.abstractmethod
def supported_boot_interfaces(self): def supported_boot_interfaces(self):
"""List of supported boot interfaces.""" """List of supported boot interfaces."""
@abc.abstractproperty @property
@abc.abstractmethod
def supported_deploy_interfaces(self): def supported_deploy_interfaces(self):
"""List of supported deploy interfaces.""" """List of supported deploy interfaces."""
@abc.abstractproperty @property
@abc.abstractmethod
def supported_management_interfaces(self): def supported_management_interfaces(self):
"""List of supported management interfaces.""" """List of supported management interfaces."""
@abc.abstractproperty @property
@abc.abstractmethod
def supported_power_interfaces(self): def supported_power_interfaces(self):
"""List of supported power interfaces.""" """List of supported power interfaces."""

9
ironic/drivers/modules/snmp.py
View File

@ -554,15 +554,18 @@ class SNMPDriverSimple(SNMPDriverBase):
super(SNMPDriverSimple, self).__init__(*args, **kwargs) super(SNMPDriverSimple, self).__init__(*args, **kwargs)
self.oid = self._snmp_oid() self.oid = self._snmp_oid()
@abc.abstractproperty @property
@abc.abstractmethod
def oid_device(self): def oid_device(self):
"""Device dependent portion of the power state object OID.""" """Device dependent portion of the power state object OID."""
@abc.abstractproperty @property
@abc.abstractmethod
def value_power_on(self): def value_power_on(self):
"""Value representing power on state.""" """Value representing power on state."""
@abc.abstractproperty @property
@abc.abstractmethod
def value_power_off(self): def value_power_off(self):
"""Value representing power off state.""" """Value representing power off state."""