openstack/ironic
Code Issues Proposed changes

Remove validate_boot_option_for_trusted_boot metric

Browse Source 
This removes the timing metric "validate_boot_option_for_trusted_boot"
because the validate_boot_parameters_for_trusted_boot() function is
an internal function that is called by PXEBoot.validate() -- which
is handled by the "PXEBoot.validate" metric. We shouldn't be emitting
metrics for such short-lived, internal functions.

Change-Id: Iaaa573fc4f128d6c3e20faf9c94259b352874eb8
This commit is contained in:
Ruby Loo 2018-02-08 18:04:43 -05:00
parent a0e08d026b
commit 9a2ebde83f
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ironic/drivers/modules/pxe.py
View File

@ -338,7 +338,6 @@ def _get_volume_pxe_options(task):
return pxe_options return pxe_options
@METRICS.timer('validate_boot_option_for_trusted_boot')
def validate_boot_parameters_for_trusted_boot(node): def validate_boot_parameters_for_trusted_boot(node):
"""Check if boot parameters are valid for trusted boot.""" """Check if boot parameters are valid for trusted boot."""
boot_mode = deploy_utils.get_boot_mode_for_deploy(node) boot_mode = deploy_utils.get_boot_mode_for_deploy(node)

6
releasenotes/notes/remove-metric-pxe-boot-option-1aec41aebecc1ce9.yaml Normal file
View File

@ -0,0 +1,6 @@
---
other:
- |
Removes the software metric named ``validate_boot_option_for_trusted_boot``.
This was the timing for a short-lived, internal function that is already
included in the ``PXEBoot.validate`` metric.