openstack/ironic
Code Issues Proposed changes

Add some missed test cases in node object tests

Browse Source 
Change-Id: Ib025178359a0ed5445b7ef495f004bdbc92fbd15
Co-Authored-By: Ruby Loo <ruby.loo@intel.com>
This commit is contained in:
Zhenguo Niu 2016-01-15 17:51:27 +08:00 committed by Dmitry Tantsur
parent c752f4928e
commit a0e08d026b
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
ironic/tests/unit/objects/test_node.py
View File

@ -75,6 +75,48 @@ class TestNodeObject(db_base.DbTestCase, obj_utils.SchemasTestMixIn):
self.assertRaises(exception.InvalidIdentity,
objects.Node.get, self.context, 'not-a-uuid')
def test_get_by_name(self):
node_name = 'test'
fake_node = db_utils.get_test_node(name=node_name)
with mock.patch.object(self.dbapi, 'get_node_by_name',
autospec=True) as mock_get_node:
mock_get_node.return_value = fake_node
node = objects.Node.get_by_name(self.context, node_name)
mock_get_node.assert_called_once_with(node_name)
self.assertEqual(self.context, node._context)
def test_get_by_name_node_not_found(self):
with mock.patch.object(self.dbapi, 'get_node_by_name',
autospec=True) as mock_get_node:
node_name = 'non-existent'
mock_get_node.side_effect = exception.NodeNotFound(node=node_name)
self.assertRaises(exception.NodeNotFound,
objects.Node.get_by_name, self.context,
node_name)
def test_get_by_instance_uuid(self):
uuid = self.fake_node['instance_uuid']
with mock.patch.object(self.dbapi, 'get_node_by_instance',
autospec=True) as mock_get_node:
mock_get_node.return_value = self.fake_node
node = objects.Node.get_by_instance_uuid(self.context, uuid)
mock_get_node.assert_called_once_with(uuid)
self.assertEqual(self.context, node._context)
def test_get_by_instance_not_found(self):
with mock.patch.object(self.dbapi, 'get_node_by_instance',
autospec=True) as mock_get_node:
instance = 'non-existent'
mock_get_node.side_effect = \
exception.InstanceNotFound(instance=instance)
self.assertRaises(exception.InstanceNotFound,
objects.Node.get_by_instance_uuid, self.context,
instance)
def test_get_by_port_addresses(self):
with mock.patch.object(self.dbapi, 'get_node_by_port_addresses',
autospec=True) as mock_get_node: