From b4f8209b99af32d8d2a646591af9b62436aad3d8 Mon Sep 17 00:00:00 2001 From: Jay Faulkner Date: Thu, 8 Jun 2023 10:01:35 -0700 Subject: [PATCH] Disabling test_upgrade_twice temporarily for CI fix This test has been taking an inordinate amount of time to complete. We should figure out the root cause and fix it, but in the meantime it only causes us harm to be unable to land patches. Related-Bug: 2023316 Change-Id: I604369e000c80914cf0c584c9deab7245c66b1b4 --- .../tests/unit/db/sqlalchemy/test_migrations.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/ironic/tests/unit/db/sqlalchemy/test_migrations.py b/ironic/tests/unit/db/sqlalchemy/test_migrations.py index aaddf1bda6..5fd765f424 100644 --- a/ironic/tests/unit/db/sqlalchemy/test_migrations.py +++ b/ironic/tests/unit/db/sqlalchemy/test_migrations.py @@ -1339,13 +1339,16 @@ class MigrationCheckersMixin(object): self.assertRaises(db_exc.DBMigrationError, self.migration_api.create_schema) - def test_upgrade_twice(self): - with patch_with_engine(self.engine): - self.migration_api.upgrade('31baaf680d2b') - v1 = self.migration_api.version() - self.migration_api.upgrade('head') - v2 = self.migration_api.version() - self.assertNotEqual(v1, v2) +# NOTE(JayF): bug2023316 means we need to disable this for now. We need +# to fix the hangs in this test then re-enable it as quickly +# as possible +# def test_upgrade_twice(self): +# with patch_with_engine(self.engine): +# self.migration_api.upgrade('31baaf680d2b') +# v1 = self.migration_api.version() +# self.migration_api.upgrade('head') +# v2 = self.migration_api.version() +# self.assertNotEqual(v1, v2) class TestMigrationsMySQL(MigrationCheckersMixin,