Follow-up on dracclient refactor

This is a follow-up on commits 72f64cce2b
and 47be8011c6.

Change-Id: Ieae9f165facd53e888194bb98f113a9eb933366e

driver-requirements.txt

@@ -14,8 +14,8 @@ python-seamicroclient>=0.4.0
 UcsSdk==0.8.2.2
 python-dracclient>=0.0.5
 
-# The amt driver import a python module called "pywsman", however, this does
+# The amt driver imports a python module called "pywsman", but this does not
-# not exist on pypi.
+# exist on pypi.
 # It is installed by the openwsman-python (on RH) or python-openwsman (on deb)
 # package, from https://github.com/Openwsman/openwsman/blob/master/bindings/python/Makefile.am#L29
 # There is *also* a "wsman" module on pypi ... but I think that's the wrong one.

ironic/drivers/modules/drac/power.py

@@ -67,13 +67,15 @@ def _commit_boot_list_change(node):
     driver_internal_info = node.driver_internal_info
 
     boot_device = node.driver_internal_info.get('drac_boot_device')
-    if boot_device is not None:
+    if boot_device is None:
-        drac_management.set_boot_device(node, boot_device['boot_device'],
+        return
-                                        boot_device['persistent'])
 
-        driver_internal_info['drac_boot_device'] = None
+    drac_management.set_boot_device(node, boot_device['boot_device'],
-        node.driver_internal_info = driver_internal_info
+                                    boot_device['persistent'])
-        node.save()
+
+    driver_internal_info['drac_boot_device'] = None
+    node.driver_internal_info = driver_internal_info
+    node.save()
 
 
 def _set_power_state(node, power_state):

releasenotes/notes/drac-migrate-to-dracclient-2bd8a6d1dd3fdc69.yaml

@@ -8,6 +8,7 @@ fixes:
     operations.
 upgrade:
   - Dependency for DRAC driver changed from ``pywsman`` to
-    ``python-dracclient``. Exceptions thrown by the driver and return values of
+    ``python-dracclient`` with version >= 0.0.5. Exceptions thrown by the
-    the ``set_bios_config``, ``commit_bios_config`` and ``abandon_bios_config``
+    driver and return values of the ``set_bios_config``, ``commit_bios_config``
-    methods changed on the vendor-passthru interface.
+    and ``abandon_bios_config`` methods changed on the vendor-passthru
+    interface.