openstack/ironic
Code Issues Proposed changes

Enable H702 PEP8 check

Browse Source 
Fixes files with the PEP8 error:

    H702  Argument to _, _LI, _LW, _LC, or _LE must be just a string

and enables the PEP8 check in tox.ini.

Change-Id: I6ca187535981d9809ca221e90de38988601f96e0
This commit is contained in:
David Shrewsbury 2014-10-10 14:11:37 -04:00
parent beda2675e1
commit bfec3234c3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ironic/conductor/manager.py
View File

@ -308,8 +308,8 @@ class ConductorManager(periodic_task.PeriodicTasks):
node.save() node.save()
LOG.warning(_LW("No free conductor workers available to perform " LOG.warning(_LW("No free conductor workers available to perform "
"an action on node %(node)s, setting node's " "an action on node %(node)s, setting node's "
"power state back to %(power_state)s.", "power state back to %(power_state)s."),
{'node': node.uuid, 'power_state': power_state})) {'node': node.uuid, 'power_state': power_state})
@messaging.expected_exceptions(exception.InvalidParameterValue, @messaging.expected_exceptions(exception.InvalidParameterValue,
exception.MissingParameterValue, exception.MissingParameterValue,

2
tox.ini
View File

@ -47,7 +47,7 @@ commands = {posargs}
[flake8] [flake8]
# E711: ignored because it is normal to use "column == None" in sqlalchemy # E711: ignored because it is normal to use "column == None" in sqlalchemy
# TODO(yuriyz): Analyze or fix the warnings blacklisted below # TODO(yuriyz): Analyze or fix the warnings blacklisted below
ignore = E12,E111,E113,E131,E265,E711,F812,H305,H307,H405,H702 ignore = E12,E111,E113,E131,E265,E711,F812,H305,H307,H405
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova* exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,*ironic/nova*
[hacking] [hacking]