openstack/ironic
Code Issues Proposed changes

Merge "Log node UUID and not entire node instance to avoid logging its driver_info field"

Browse Source
This commit is contained in:
Zuul
2024-07-29 14:28:02 +00:00
committed by Gerrit Code Review
parent 6d550c064c 88ad9a7bbf
commit c375a01ecb
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/conductor/cleaning.py
View File

@@ -54,7 +54,7 @@ def do_node_clean(task, clean_steps=None, disable_ramdisk=False):
how = ('API' if node.automated_clean is False else 'configuration')
LOG.info('Automated cleaning is disabled via %(how)s, node %(node)s '
'has been successfully moved to AVAILABLE state',
{'how': how, 'node': node})
{'how': how, 'node': node.uuid})
return
# NOTE(dtantsur): this is only reachable during automated cleaning,

7
releasenotes/notes/remove-node-object-from-log-statement-f1b92a8ca26686c2.yaml Normal file
View File

@@ -0,0 +1,7 @@
---
security:
- |
Log the node UUID instead of the full node object in
ironic/conductor/cleaning.py, to avoid logging the node's driver_info
property (containing its BMC username and password).