openstack/ironic
Code Issues Proposed changes

Fix ilo boot interface order

Browse Source 
This change aligns the boot interface order of the ilo
hardware type to match the other hardware type interface
order lists.

This change is a result of an operator reporting inconsistent
behavior of ironic when they are adding nodes using the ilo
hardware type, where they would default to use the "pxe" boot
interface, where as the other interfaces would end up defaulting
to "ipxe".

Change-Id: I3d848af284545a7a1fb1e065f09fe2df6a9114ac
This commit is contained in:
Julia Kreger 2022-07-26 07:40:24 -07:00
parent c861423eb5
commit c921c077d4
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/ilo.py
View File

@ -37,7 +37,7 @@ class IloHardware(generic.GenericHardware):
@property @property
def supported_boot_interfaces(self): def supported_boot_interfaces(self):
"""List of supported boot interfaces.""" """List of supported boot interfaces."""
return [boot.IloVirtualMediaBoot, boot.IloPXEBoot, boot.IloiPXEBoot] return [boot.IloVirtualMediaBoot, boot.IloiPXEBoot, boot.IloPXEBoot]
@property @property
def supported_bios_interfaces(self): def supported_bios_interfaces(self):

26
releasenotes/notes/fix-ilo-boot-interface-order-238a2da9933cf28c.yaml Normal file
View File

@ -0,0 +1,26 @@
---
fixes:
- |
Fixes the default boot interface order for the ``ilo`` hardware type
where previously it would prefer ``pxe`` over ``ipxe``. This created
inconsistencies for operators using multiple hardware types, where
both interfaces were enabled in the deployment.
upgrade:
- |
Operators who are upgrading should be aware that a bug was discovered
with the automatic selection of ``boot_interface`` for users of the
``ilo`` and ``ilo5`` hardware types. This was an inconsistency,
resulting in ``pxe`` being selected instead of ``ipxe`` if both
boot interfaces were enabled. Depending on the local configuration,
this may, or may not have happened and will remain static on
preexisting baremetal nodes. Some users may have been relying
upon this incorrect behavior by having misalligned defaults by trying
to use the ``pxe`` interface for ``ipxe``. Users wishing to continue
this usage as it was previously will need to explicitly set a
``boot_interface`` value to either ``pxe`` or ``ilo-ipxe`` by default,
depending on the local configuration. Most operators have leveraged
the default examples, and thus did not explicitly encounter this
condition. Operators explicitly wishing to use ``pxe`` boot interfaces
with the ``ipxe`` templates and defaults set to override the defaults
for ``ironic.conf`` will need to either continue to leverage default
override configurations in their ``ironic.conf`` file.