From dcd701b4a08ff7e02fbce3171858284e7ff53204 Mon Sep 17 00:00:00 2001
From: Ilya Etingof <etingof@gmail.com>
Date: Tue, 5 Nov 2019 15:29:19 +0100
Subject: [PATCH] Add a CI job to legacy boot over Redfish virtual media

Adds a job to boot a node over Redfish virtual media in legacy
BIOS boot mode. For sake of unification, similar PXE job has been
renamed.

Apparently, libvirt-based Redfish BMC emulation requires node
power-cycle for libvirt domain configuration changes to take
effect.

Change-Id: I2c7fc26b082db6eeae1abcd67362884a9c72c109
---
 devstack/tools/ironic/templates/vm.xml |  2 +-
 zuul.d/ironic-jobs.yaml                | 22 ++++++++++++++++++++--
 zuul.d/project.yaml                    |  6 ++++--
 3 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/devstack/tools/ironic/templates/vm.xml b/devstack/tools/ironic/templates/vm.xml
index 3fa2a608ba..d2b3c00710 100644
--- a/devstack/tools/ironic/templates/vm.xml
+++ b/devstack/tools/ironic/templates/vm.xml
@@ -26,7 +26,7 @@
   </features>
   <clock offset='utc'/>
   <on_poweroff>destroy</on_poweroff>
-  <on_reboot>restart</on_reboot>
+  <on_reboot>destroy</on_reboot>
   <on_crash>restart</on_crash>
   <devices>
     <emulator>{{ emulator }}</emulator>
diff --git a/zuul.d/ironic-jobs.yaml b/zuul.d/ironic-jobs.yaml
index 90b640153b..59663fe568 100644
--- a/zuul.d/ironic-jobs.yaml
+++ b/zuul.d/ironic-jobs.yaml
@@ -134,8 +134,8 @@
         s-proxy: True
 
 - job:
-    name: ironic-tempest-ipa-partition-redfish-tinyipa
-    description: ironic-tempest-ipa-partition-redfish-tinyipa
+    name: ironic-tempest-partition-bios-redfish-pxe
+    description: "Deploy ironic node over PXE using BIOS boot mode"
     parent: ironic-base
     timeout: 5400
     required-projects:
@@ -144,6 +144,24 @@
       devstack_localrc:
         IRONIC_DEPLOY_DRIVER: redfish
         IRONIC_ENABLED_HARDWARE_TYPES: redfish
+        IRONIC_ENABLED_POWER_INTERFACES: redfish
+        IRONIC_ENABLED_MANAGEMENT_INTERFACES: redfish
+
+- job:
+    name: ironic-tempest-partition-bios-redfish-vmedia
+    description: "Deploy ironic node over Redfish virtual media using legacy BIOS boot mode"
+    parent: ironic-tempest-partition-bios-redfish-pxe
+    vars:
+      devstack_localrc:
+        IRONIC_ENABLED_BOOT_INTERFACES: redfish-virtual-media
+        IRONIC_VM_SPECS_RAM: 512
+        SWIFT_ENABLE_TEMPURLS: True
+        SWIFT_TEMPURL_KEY: secretkey
+      devstack_services:
+        s-account: True
+        s-container: True
+        s-object: True
+        s-proxy: True
 
 - job:
     name: ironic-tempest-pxe_ipmitool-postgres
diff --git a/zuul.d/project.yaml b/zuul.d/project.yaml
index 51148dfbda..b366857772 100644
--- a/zuul.d/project.yaml
+++ b/zuul.d/project.yaml
@@ -16,8 +16,9 @@
         # Temporary disable voting because of end of cycle CI instability.
         - ironic-grenade-dsvm-multinode-multitenant:
             voting: false
+        - ironic-tempest-partition-bios-redfish-pxe
+        - ironic-tempest-partition-bios-redfish-vmedia
         - ironic-tempest-ipa-partition-pxe_ipmitool-tinyipa
-        - ironic-tempest-ipa-partition-redfish-tinyipa
         - ironic-tempest-ipa-partition-uefi-pxe_ipmitool-tinyipa
         - ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode:
             voting: false
@@ -52,8 +53,9 @@
         - ironic-grenade-dsvm
         # removing from voting due to end of cycle gate instability.
         # - ironic-grenade-dsvm-multinode-multitenant
+        - ironic-tempest-partition-bios-redfish-pxe
+        - ironic-tempest-partition-bios-redfish-vmedia
         - ironic-tempest-ipa-partition-pxe_ipmitool-tinyipa
-        - ironic-tempest-ipa-partition-redfish-tinyipa
         - ironic-tempest-ipa-partition-uefi-pxe_ipmitool-tinyipa
         # removing from voting due to end of cycle gate instability.
         # - ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode