From b0b7ee425430745ead6eb43d218d7a515da63e23 Mon Sep 17 00:00:00 2001 From: Jay Faulkner Date: Fri, 29 Dec 2023 10:59:42 -0800 Subject: [PATCH] Do not log lack of metrics support at WARNING lvl We have some drivers, such as SNMP, which do not support metrics. Environments with these nodes should not get "N" messages for "N" nodes that can't generate sensor data. Closes-bug: 2047709 Change-Id: Ibc1f3feb055521214512c8b350d67933491c2550 --- ironic/conductor/manager.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ironic/conductor/manager.py b/ironic/conductor/manager.py index 5efa3f66af..f93e31c74e 100644 --- a/ironic/conductor/manager.py +++ b/ironic/conductor/manager.py @@ -2626,7 +2626,11 @@ class ConductorManager(base_manager.BaseConductorManager): sensors_data = task.driver.management.get_sensors_data( task) except NotImplementedError: - LOG.warning( + # NOTE(JayF): In mixed deployments with some nodes supporting + # sensor data and others not, logging this at warning level + # creates unreasonable levels of logging noise. + # See https://bugs.launchpad.net/ironic/+bug/2047709 + LOG.debug( 'get_sensors_data is not implemented for driver' ' %(driver)s, node_uuid is %(node)s', {'node': node_uuid, 'driver': driver})