From f03c09d3cf72a685052b1606b7281418f9a09feb Mon Sep 17 00:00:00 2001 From: Zhenguo Niu Date: Tue, 15 Mar 2016 15:09:11 +0800 Subject: [PATCH] Remove unneeded 'wait=False' to be more clean and consistent No need to specify 'wait=False' when calling AgentClient._command(), it's the default value. Change-Id: Ib7490f4a73dee3ecd4b2eb2aeeab1c94fc4fce49 --- ironic/drivers/modules/agent_client.py | 3 +-- ironic/tests/unit/drivers/modules/test_agent_client.py | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/ironic/drivers/modules/agent_client.py b/ironic/drivers/modules/agent_client.py index d3bedeb1d2..46ca563699 100644 --- a/ironic/drivers/modules/agent_client.py +++ b/ironic/drivers/modules/agent_client.py @@ -161,8 +161,7 @@ class AgentClient(object): } return self._command(node=node, method='clean.execute_clean_step', - params=params, - wait=False) + params=params) def power_off(self, node): """Soft powers off the bare metal node by shutting down ramdisk OS.""" diff --git a/ironic/tests/unit/drivers/modules/test_agent_client.py b/ironic/tests/unit/drivers/modules/test_agent_client.py index 39e45db0b9..420040859b 100644 --- a/ironic/tests/unit/drivers/modules/test_agent_client.py +++ b/ironic/tests/unit/drivers/modules/test_agent_client.py @@ -212,7 +212,7 @@ class TestAgentClient(base.TestCase): ports) self.client._command.assert_called_once_with( node=self.node, method='clean.execute_clean_step', - params=expected_params, wait=False) + params=expected_params) def test_power_off(self): self.client._command = mock.MagicMock(spec_set=[])