From 952d5c5a06f35181768e52dd660afe548bc6fa60 Mon Sep 17 00:00:00 2001 From: Lucas Alvares Gomes Date: Wed, 9 Dec 2015 16:17:30 +0000 Subject: [PATCH] Fix iPXE template for whole disk image The goto :boot_whole_disk section in the iPXE template is bogus, the "kernel" command is being used to chain the "chain.c32" file, that command should be "chain" and the "append" command is not a valid iPXE command. This patch replaces those commands with the "sanboot" command from iPXE which is (among other things) used to chain the boot process to the local disk. Closes-Bug: #1524403 Change-Id: I7d2310d94e40b1c9c76957382ab19c0076bf42cd --- ironic/drivers/modules/ipxe_config.template | 4 +--- ironic/tests/unit/drivers/ipxe_config.template | 4 +--- ...x-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml | 4 ++++ 3 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 releasenotes/notes/fix-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml diff --git a/ironic/drivers/modules/ipxe_config.template b/ironic/drivers/modules/ipxe_config.template index 062776cc8f..9564301177 100644 --- a/ironic/drivers/modules/ipxe_config.template +++ b/ironic/drivers/modules/ipxe_config.template @@ -16,6 +16,4 @@ initrd {{ pxe_options.ari_path }} boot :boot_whole_disk -kernel chain.c32 -append mbr:{{ DISK_IDENTIFIER }} -boot +sanboot --no-describe diff --git a/ironic/tests/unit/drivers/ipxe_config.template b/ironic/tests/unit/drivers/ipxe_config.template index bc803d4a77..1ca14c8f3b 100644 --- a/ironic/tests/unit/drivers/ipxe_config.template +++ b/ironic/tests/unit/drivers/ipxe_config.template @@ -16,6 +16,4 @@ initrd http://1.2.3.4:1234/ramdisk boot :boot_whole_disk -kernel chain.c32 -append mbr:{{ DISK_IDENTIFIER }} -boot +sanboot --no-describe diff --git a/releasenotes/notes/fix-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml b/releasenotes/notes/fix-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml new file mode 100644 index 0000000000..b0ceb5b11a --- /dev/null +++ b/releasenotes/notes/fix-ipxe-template-for-whole-disk-image-943da0311ca7aeb5.yaml @@ -0,0 +1,4 @@ +--- +fixes: + - Fixes an issue with the provided iPXE template where whole disk images + could not be booted. See https://bugs.launchpad.net/ironic/+bug/1524403.