7933 Commits

Author SHA1 Message Date
Mark Goddard
ccf22acb53 Fix nits found in node traits
Includes:

* Return a location in HTTP response header for PUT
  /nodes/<node>/traits/<trait>.
* Correct order of arguments to assertEqual() in conductor manager unit
  tests for traits.
* Use () rather than \ for multiline formatting.
* Set tags and traits fields on NodeModel to default of [] in DB node
  create after DB insert.

Change-Id: Ia88f7ca69b777b82caca2871e44edab39f2a8310
Partial-Bug: #1722194
2018-01-30 10:01:26 -05:00
paresh-sao
bf304a62e3 Follow-up for Implementation for UEFI iSCSI boot for ILO
This patch addresses outstanding comments for commit
87636372559fa6d83bb51eaaae075ac5e5575c17

Change-Id: I106f36cc3e9be2dee862e13d8e6621328e4f7959
2018-01-30 07:11:03 +00:00
Zuul
cd406b977c Merge "Explicitly mark earliest-version for release notes" 2018-01-30 00:14:42 +00:00
Jim Rollenhagen
3b8c3879a5 Explicitly mark earliest-version for release notes
This uses reno's `earliest-version` directive to explicitly point out
where the release notes for a given branch should begin. There is a bug
in reno when dealing with stable branches, where it does not always find
the correct version to begin with.

It also updates our release docs to indicate we should continue marking
this. This step can be removed when the reno bug is fixed, though it
doesn't hurt to continue marking this explicitly.

Change-Id: I6502ff95a52c2c855356e9875291f27ec44e7ffa
Related-Bug: #1746076
2018-01-29 14:15:01 -05:00
Ruby Loo
dfa888bf69 Remove unused code in common/neutron.py
This remove a line of code that is never executed, and if it were
to be executed, is incorrect, since the variable doesn't exist.

This is a follow up to 78e689e5390acf0d18b433c05495628012466c61.

Change-Id: Ic6085c8c070539ca383d0625a1c44ab9e31e1527
2018-01-29 09:55:45 -05:00
zhangdebo
e3f4a90f2b Correct link address
Link address for config drive is out of date, so correct it.

Change-Id: Ib77a5bd92c1409a02570f691f4edeb90eab107e0
2018-01-29 19:22:02 +08:00
Harald Jensas
d2da4150ea Wait for ironic-neutron-agent to report state
Wait for the agent to finish reporting state, bridge_mappings
must be reported prior to any cleaning attempts.

Change-Id: I041761dd896c9d89dc6cf7bafc991a0697ded05b
Related-Bug: #1658964
2018-01-29 11:07:41 +01:00
Harald Jensas
d0d78a86de Devstack - use neutron segments (routed provider networks)
When IRONIC_USE_NEUTRON_SEGMENTS is True:
* The provisioning subnet is associated with the segment on the
  provisioning network.
* The baremetal node ports is created with --physical-network set.

The neutron segments service_plugin must be enabled to allow
associating the subnet with the segment.

Change-Id: Ie6dcebf24413c65ecdc3e0c56cc56f8d88dc406c
2018-01-29 11:07:33 +01:00
Hoang Trung Hieu
f5b52696fb Zuul: Remove project name
Zuul no longer requires the project-name for in-repo configuration.
Omitting it makes forking or renaming projects easier.

Change-Id: Iff03f999769671adafdb46b22c64e80708d62d0e
2018-01-29 12:55:35 +07:00
Mark Goddard
c9677cd43b Add traits field to node notifications
Adds a traits field to node notifications, and triggers notifications
when node traits are added or removed. Node traits are emitted in
notifications as a list of trait name strings.

Bumps the following notification payload versions:

NodePayload: 1.6
NodeSetPowerStatePayload: 1.6
NodeCorrectedPowerStatePayload: 1.6
NodeSetProvisionStatePayload: 1.6
NodeCRUDPayload: 1.4

Change-Id: I4e0333173250a641b317d466e52742cf7728ed90
Partial-Bug: #1722194
2018-01-28 09:12:13 +00:00
Zuul
180234b445 Merge "Update description for config params of 'rescue' interface" 2018-01-28 06:07:14 +00:00
Zuul
ab9b7afe7d Merge "Add rescue interface field to node-related notifications" 2018-01-28 05:23:02 +00:00
Zuul
131f7a31e0 Merge "Follow-up for API methods for rescue implementation" 2018-01-27 17:15:05 +00:00
Zuul
91561c8835 Merge "Add a timeout for powering on/off a node on oneview" 2018-01-27 10:58:41 +00:00
Zuul
2f85ad321d Merge "Fix persistent information when getting boot device" 2018-01-27 10:43:59 +00:00
Zuul
0a5de20c2a Merge "Remove python-oneviewclient from oneview hardware type." 2018-01-27 10:43:55 +00:00
Shivanand Tendulker
b9b4a55a41 Update description for config params of 'rescue' interface
As ``rescue`` API implementation has merged, we can let users use
configuration parameters related to this feature. This patch fixes
the help messages for the same.

Change-Id: Idab95302011c3bb3f1db560a6a3f9481371e7671
Partial-bug: #1526449
2018-01-27 09:20:04 +00:00
Shivanand Tendulker
7394dbbacb Add rescue interface field to node-related notifications
This patch adds rescue_interface field to node-related notification
objects.

Co-Authored-By: Jay Faulkner <jay@jvf.cc>
Co-Authored-By: Josh Gachnang <josh@pcsforeducation.com>
Co-Authored-By: Jesse J. Cook <jesse.j.cook@member.fsf.org>
Co-Authored-By: Mario Villaplana <mario.villaplana@gmail.com>
Co-Authored-By: Aparna <aparnavtce@gmail.com>
Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com>

Change-Id: I8aa4c3c4701eae5f7838192bdbcf46a069370643
Partial-bug: #1526449
2018-01-27 09:19:47 +00:00
Zuul
68f566160d Merge "Resolve race in validating neutron networks due to caching" 2018-01-27 05:31:22 +00:00
Shivanand Tendulker
45d542e4b9 Follow-up for API methods for rescue implementation
This patch addresses outstanding comments for commit
49fabe6d7b7051cb78d6f7904a62ab6ae2bd8c0f

Change-Id: I566b219bc235c2dd318dfd0bd1a1b61f7757a88e
Related-Bug: #1526449
2018-01-26 23:15:01 -05:00
Shivanand Tendulker
45e7cadb6f Add support for preparing rescue ramdisk in iLO PXE
Adds support to prepare rescue ramdisk to 'ilo-pxe' boot
interface, which is a subclass of 'pxe' boot interface by
adding the new argument.

Change-Id: Ie486476bfb2ef3ccb30e4b3bb13ec2ee350bfcfd
Related-Bug: #1526449
2018-01-26 23:03:49 -05:00
Zuul
359c882dcd Merge "Redundant alias in import statement" 2018-01-27 01:45:09 +00:00
Zuul
9e29d77988 Merge "Automatically migrate nodes to hardware types" 2018-01-27 01:12:28 +00:00
Zuul
cb2b2d191a Merge "iRMC:Support preparing rescue ramdisk in iRMC PXE" 2018-01-27 00:33:45 +00:00
Zuul
96010a07a4 Merge "Add API methods for [un]rescue" 2018-01-26 23:57:32 +00:00
Dmitry Tantsur
cc6f7bc73e Automatically migrate nodes to hardware types
This change adds a new data migration: migrate_to_hardware_types.
It works by walking through known classic drivers, detecting matching
hardware types and interfaces and updates nodes accordingly.

Nodes that cannot be updated (e.g. matching hardware type is not
enabled) are skipped. A new migration option reset_unsupported_interfaces
can be set to True to allow resetting optional interfaces to their
no-op versions.

The example implementation are provided for the community supported
IPMI and SNMP drivers, as well as for fake drivers based on them.

Change-Id: I732b44f2ab1ef73f56b352415ffd9cdd8a0e232b
Partial-Bug: #1690185
2018-01-26 21:17:26 +00:00
Jay Faulkner
49fabe6d7b Add API methods for [un]rescue
Adds API methods to support rescue and unrescue.

After rescuing a node, it will be left running a rescue ramdisk,
configured with the rescue_password, and listening with ssh on the
specified network interfaces.

Unrescuing a node will return the node to Active.

Change-Id: I3953ff0b1ca000f8ae83fb7b3c663f848a149345
Partial-bug: #1526449
Co-Authored-By: Jay Faulkner <jay@jvf.cc>
Co-Authored-By: Josh Gachnang <josh@pcsforeducation.com>
Co-Authored-By: Jesse J. Cook <jesse.j.cook@member.fsf.org>
Co-Authored-By: Mario Villaplana <mario.villaplana@gmail.com>
Co-Authored-By: Aparna <aparnavtce@gmail.com>
Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com>
2018-01-26 18:27:10 +00:00
Javier Pena
98570dc6ad Fix unit tests for UEFI iSCSI boot for ILO
https://review.openstack.org/468288 added some unit tests for the
UEFI iSCSI boot for ILO, which fail when proliantutils is installed
in the virtualenv (it was not in the gate).

The reason for this is that they do not pass a value to the constructor
of ilo_error.IloError and ilo_error.IloCommandNotSupportedInBiosError,
which makes the unit tests fail, as seen when the package was built
in RDO [1].

This patch adds the required value, as used by other unit tests.

[1] - 7371477064_0520bb51

Change-Id: I50d919047ddb9edf1a1ae1a994a8f71e420718d9
2018-01-26 17:01:28 +01:00
Shivanand Tendulker
a05c8ef8c7 Follow-up for agent rescue implementation
This patch addresses outstanding comments for commit
4624c572e21f136db5df8ebcd0ddae03eed71a59

Change-Id: I672ca923ce511b30e62a68140f00bb6256008efe
Related-Bug: #1526449
2018-01-26 10:15:24 -05:00
Zuul
e95f3de5c9 Merge "Updated from global requirements" 2018-01-26 14:59:47 +00:00
Hironori Shiina
b5a8953118 iRMC:Support preparing rescue ramdisk in iRMC PXE
Adds support to prepare rescue ramdisk to iRMC PXE boot interface,
which is a subclass of PXE boot interface by adding the new argument.

Also adds unit tests to confirm iRMC PXE boot interface passes the
same tests as generic PXE boot interface.

Change-Id: I1b4aeb207772a09cacf0bff910be4061ec5c74ee
Related-Bug: #1526449
2018-01-26 23:52:45 +09:00
Zuul
ca0cff144a Merge "Agent rescue implementation" 2018-01-26 12:03:24 +00:00
Luong Anh Tuan
ddac41b8de Redundant alias in import statement
Change-Id: I217563ed7509d89a0ebd46858c523c04193d1d98
2018-01-26 09:19:59 +07:00
Zuul
7371477064 Merge "Implementation for UEFI iSCSI boot for ILO" 2018-01-25 23:06:36 +00:00
Zuul
3258662dc4 Merge "Allow data migrations to accept options" 2018-01-25 22:50:18 +00:00
Shivanand Tendulker
4624c572e2 Agent rescue implementation
This implements agent based rescue interface.

Partial-Bug: #1526449

Co-Authored-By: Mario Villaplana <mario.villaplana@gmail.com>
Co-Authored-By: Aparna <aparnavtce@gmail.com>
Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com>

Change-Id: I9b4c1278dc5fab7888fbfe586c15e31ed3958978
2018-01-25 13:26:33 -05:00
Zuul
b539a6e256 Merge "[docs] mention new nova scheduler option" 2018-01-25 17:08:54 +00:00
Dmitry Tantsur
d8f10c01ae Allow data migrations to accept options
This allows migration to be tuned to a specific deployment. For example,
when we will migrate nodes to hardware types, an option will be used
to specify what to do with missing interfaces.

Change-Id: Ie5045b20b7420fc9b5d864bfb18258a4d8b93334
Related-Bug: #1690185
2018-01-25 16:51:42 +00:00
Sam Betts
78e689e539 Resolve race in validating neutron networks due to caching
This patch removes the caching from the code that validates neutron
network's name and UUID to solve a race caused by storing a network UUID
(which can now be different per node) on a singleton network interface
object.

Change-Id: Ib5fb1ff93ffecec4b5ffb033013d3ae09dcaf4bc
2018-01-25 15:41:31 +00:00
Zuul
f5654bfd00 Merge "Allow setting {provisioning,cleaning,rescuing}_network in driver_info" 2018-01-25 11:54:26 +00:00
Kaifeng Wang
0386a4f966 Update api-ref for port group create
Update the facts that name and MAC address is not mandatory when
creating port groups.

Change-Id: I214cdab5789923341cdb2100b425958df6053d68
2018-01-25 16:41:55 +08:00
kesper
8763637255 Implementation for UEFI iSCSI boot for ILO
This change adds new methods in management interface and enhance
boot interface of 'ilo' hardware type to support boot from iSCSI
volume in UEFI boot mode.

Change-Id: I585e0ef90f4397af1f09920c3a1bc47ddbcb1a97
Related-Bug: #1526861
2018-01-25 06:33:21 +00:00
Zuul
a8a57048eb Merge "Add node traits to API reference" 2018-01-25 05:20:11 +00:00
Zuul
33e19070ec Merge "API: Node Traits API" 2018-01-25 05:20:08 +00:00
Zuul
e98540f08d Merge "Add RPC API and conductor manager for traits" 2018-01-25 03:48:59 +00:00
Zuul
bafc12aaf3 Merge "Be more sane about cleaning" 2018-01-25 02:55:42 +00:00
Zuul
5854f8caf5 Merge "Fix node update with PostgreSQL" 2018-01-25 02:14:44 +00:00
Mark Goddard
223e9b1faa Add node traits to API reference
The node traits API was added in API microversion 1.37.

Change-Id: I8c48f2e7662ae9641ec823dc3802d5979a7ea03e
Partial-Bug: #1722194
2018-01-25 01:36:54 +00:00
Hugo Nicodemos
b47d251152 Add a timeout for powering on/off a node on oneview
There is an aditional timeout parameter when powering on/off
an Ironic node that is not being used at ``oneview`` hardware
type.

Change-Id: Ie6006cd40c8b2895d7326eec680be071bb871838
Closes-Bug: 1722616
2018-01-25 01:33:15 +00:00
Hugo Nicodemos
5847431e9c Fix persistent information when getting boot device
This patches fixes the get_boot_device methods for ``oneview``
hardware type to consider onetime boot option on the machine's iLO.
if onetime boot is set to 'Once' on iLO, the method will return
persistent as False (not persistent), True otherwise (persistent).

Change-Id: I48d8b01ff37263a19c889f242a7ce2a99eee597e
Closes-Bug: #1706725
2018-01-25 01:31:50 +00:00