We currently enable the fake classic driver by default, so it makes
sense to enable fake-hardware now that the classic drivers are
deprecated. It will be used in the updated ironic-inspector
discovery CI job.
Change-Id: I42e72312821b2d3c002f16fbf8b4faa26b4853b3
This change adds support for assiging traits to nodes in the ironic
devstack plugin. The set of traits added is configured by
IRONIC_DEFAULT_TRAITS, which defaults to a single trait - CUSTOM_GOLD
Using nodes with traits during testing ensures that we are exercising
node traits code paths in the Ironic CI.
Node traits are not used for upgrade testing, as the queens devstack
plugin does not currently register traits. Once this change is
backported to queens, we can enable traits during upgrade testing.
Change-Id: I18b9dbf8a5b16e36e0cc14f290b12ffdd634364a
Related-Bug: #1722194
Related-Bug: #1750027
While generally supported by iPXE, in DevStack we do not have any
facilities in place to boot iPXE from a HTTPS URL when the server is
using a custom certificate.
This is moslty concerning ability to boot iPXE directly from Swift's
TempURL when SSL is enabled on Swift in DevStack.
Just die with proper message when IRONIC_IPXE_USE_SWIFT and tls-proxy
are both enabled.
Change-Id: Ie0e01828f05b2706d310d8110e6e8dd8c4a03e4e
We're defaulting to 'latest' in ironicclient now, so only use
it if IRONIC_DEFAULT_API_VERSION is overriden.
Change-Id: Ifa813a9f0980e7d9c65166ef288d0c6f273ba521
Now we have docs, lets point people there rather than attempting to
maintain a copy in tree.
Also update the devstack plugin to know nothing about policy.json, as it
never allowed for customizing the location or the contents anyhow, and
to build ironic.conf from scratch rather than from the sample.
Change-Id: I10a4987204eb335f1fed29d4b1d7f3e075aa1792
Wait for the agent to finish reporting state, bridge_mappings
must be reported prior to any cleaning attempts.
Change-Id: I041761dd896c9d89dc6cf7bafc991a0697ded05b
Related-Bug: #1658964
When IRONIC_USE_NEUTRON_SEGMENTS is True:
* The provisioning subnet is associated with the segment on the
provisioning network.
* The baremetal node ports is created with --physical-network set.
The neutron segments service_plugin must be enabled to allow
associating the subnet with the segment.
Change-Id: Ie6dcebf24413c65ecdc3e0c56cc56f8d88dc406c
Seems that by default we now run cleaning
on all jobs. However, this is extremely wasteful
and time consuming. Also, if a cloud is IO resource
constrained, it can result in jobs failing erroneously
due to unpredictable IO performance, particularly with
the multinode jobs.
As such, slightly extend the wait timeout before we
fail for nodes not being ready, and flag multinode
jobs not to run cleaning.
Change-Id: I12011743fa197caef08a3d6d1297d662dfa7640a
Note that the job names are not changed to reduce the diff of this
patch. They will be renamed in later changes.
For the direct deploy, copy Swift temporary URL configuration from
devstack-gate (it hardcoded agent_* there).
Also clean up no-op conditions on drivers left from the times when
the job definitions were parametrized.
Change-Id: Ib0297f8936bba9449a02fb1a878981ab55687ef9
Partial-Bug: #1690185
- enable ansible deploy interface
- install Ansible version from driver-requirements.txt
- generate private SSH key to use by Ansible (if absent)
- add the public ssh key to the tinyipa image during (re)build
By default nodes are not enrolled with it, as they will be assigned this
driver/interface in standalone tests.
For local development, nodes can be enrolled by setting
IRONIC_DEFAULT_DEPLOY_INTERFACE=ansible
in local.conf and enabling 'ansible' deploy interface in the
IRONIC_ENABLED_DEPLOY_INTERFACES variable.
Change-Id: I12c1727c3ded13c381852334cb54e5e976154e98
This wasn't installed for me on a devstack run on a fresh RHEL 7.4 box.
Make sure it's installed as we depend on it by default.
Change-Id: I4faadb2d73afd298ffb1b7690b23f72800123f77
Added in change I2bbdac5cd431e72517cb1c72bb925660ec8e868b,
ironic needed to run the multi-node jobs in singleconductor
mode because they rely on reschedules working in nova, which
doesn't work in superconductor mode where the top-level conductor
and scheduler are on a different message queue from the compute
service and cell conductor.
With the alternate hosts series in nova in Queens, we should have
the reschedule problem fixed such that when originally scheduling,
we not only get a target host but also a list of alternates for
retries within the cell. This allows us to run ironic multi-node
CI jobs (and all ironic non-upgrade related jobs for that matter)
in the default superconductor mode which is the recommended way
to run nova with cellsv2.
Depends-On: Iae904afb6cb4fcea8bb27741d774ffbe986a5fb4
Depends-On: Ie599968d9e7537e551fe6d9deb63a91b256b1e11
Change-Id: I755243abed054e6b6556a9a9498e565042293262
removes code that allowed some service sections to not have and use
keystoneauth adapter options.
Also deprecates `[keystone]region_name` option in favor of per-client
option of the same name.
Change-Id: Ifd58947b016bfa93b516dd47a170ba8f5abf277e
Closes-Bug: #1699547
deprecates the following options in [neutron] section:
- url
- url_timeout
- auth_strategy
Changes some internal networking-related functions/methods
to accept a request context as optional keyword argument (defaults to
None).
This allows to pass a global request id to neutron client and
in future will simplify creating a user auth plugin from request
context.
For backward compatibility, when calling those functions/methods
without a request context, a dummy request context will be generated
automatically.
Change-Id: Ib327c7a141cfbca63b870027ad8e901c0f48bb2d
Partial-Bug: #1699547
In many cases, including devstack and TripleO, the swift account to use
is based on the project_id of the 'service' project, so it makes sense
to use it as a default.
Similarly, the temporary URL key can be fetches from Swift, using HEAD
on the account used to access it.
In both cases it is assumed that the same project is used by Ironic
and Glance to access Swift. Explicit values have to be provided
otherwise.
Finally, the endpoint URL can be fetched from the service catalog. Care
is taken to strip the /v1/AUTH_<tenant ID> suffix.
Closes-Bug: #1737714
Change-Id: I701899928f0f780939f17aabc59eb90593ba95f0
in the change I52f1386df45ebe0a43b11fe1583e012dfa3af532
we lost most of swiftclient options in a belief that those are handled
by the keystoneauth session passed to the swiftclient.
In fact though, swiftclient only uses this session to get itself an
endpoint and a token, but it has no SessionClient, and does not use that
passed in session to make further requests to swift itself.
This patch restores all the logic that we had to decompose the session
object loaded from config to options that are passed to swiftclient
explicitly.
Change-Id: I08f382aa9d2ad22f7dbd65f7b54a8dd0a765ba44
Partial-Bug: #1699547
Closes-Bug: #1736158
This change to devstack plugin code checks if `sushy-tools`
has been requested to be pulled from git rather than pypi.
This is a prerequisite for `sushy-tools` CI job to test the
Redfish emulator against Ironic conductor.
Change-Id: I548f5a19a266436edbb874ea14af67db711240be
Inspector-client is a bit lacking behind other clients, as it does not
have Adapter-based SessionClient and thus does not support all
adapter-related options.
That's why we construct a session and an adapter from config section,
use adapter to resolve inspector API from service catalog
(or return the fixed endpoint_override one)
and then pass the session and inspector API endpoint to client.
This patch also deprecates `[inspector]service_url` in favor of
`[inspector]endpoint_override`.
As a side-effect, addressig inspector service now supports both regions
and interfaces to specify entry in service catalog.
Also, inspectorclient calls are now being made with the user token
(wrapped with a service token) when there is a token in the task's
request context.
Change-Id: I21836e712fa9764468ac2654525554b5b4f03741
Partial-Bug: #1699547
this patch changes the way glance client is instantiated, using
keystoneauth sessions and adapters.
In order to support glance API endpoint discovery from keystone catalog
and more unified way of client loading,
many options in `[glance]` config sections are deprecated,
mostly those that specified a (set of) glance API endpoint(s)
or parts of glance API address.
Instead, a single option `[glance]endpoint_override` must be used when
required to access a specific (possibly load-balanced)
glance API endpoint without discovering it from keystone catalog.
Another set of deprecated options are those that are duplicating
keystoneauth session options in [glance] section.
Also, intrinsic support for parsing the glance API URL from image ref
set to the full glance REST path to the image is removed as it was not
working any way since an 'http(s)://' image ref is not treated
as a glance image.
Change-Id: I6a93b71ac097e951dfc93fd1ee4d7ef483514f2c
Partial-Bug: #1699547
Closes-Bug: #1699542
This change moves our devstack plugin away from using the old
scheduling properties: memory_mb, local_gb and cpus. Nova will
stop using them for scheduling in Queens.
The cpu_arch property is left intact, as it's still useful.
The Placement API is polled to determine when nodes are fully exposed
to nova instead of polling the hypervisor stats. cURL + jq are used,
as the Placement OSC plugin is not ready yet.
Change-Id: I497a992bd86e8a359f333d6936621d1136d68061
When installing devstack, found there is
a missing node id in devstack/lib/ironic
when root devices are less than 4Gb.
Change-Id: I331bfe1e6481dc0de2869166fc6a2a0398314735
Closes-Bug: #1730526
Mostly inspired by some comments left in the review of commit
aa5fd8afdc31b95c1a5f91f8af5fa733c4afd121 (Allow to set default ifaces
in DevStack)
Sorted the list of enabled interfaces and the default interface
values.
Used a local variable to store the uppercase value, in order to make
the code more readable as people may not immediately know what
${var^^} does in bash.
Change-Id: Ic2b2ac0a3cea9fa39173c5e2f5a9eaa3f4d8d2e4
as we move toward deprecating classic drivers,
we need a way to specify which particular combination
of interfaces of a hw type to assign to nodes being enrolled
and run test against.
This patch adds a number of IRONIC_DEFAULT_<>_INTERFACE
variables to devstack plugin (all empty by default)
and if set, sets their value as "[DEFAULT]default_<>_interface"
config option.
Change-Id: I9fc22125ddd3c70ff37185d025df1dfa3217a782
This patch replace tap interfaces by veth pairs which
ensures that port is always present in ovs even when VM
is powered off.
Closes-Bug: #1722158
Change-Id: I04ff6a97bebf15636a794b51f748c62eda627d36
Comment some of the variables related to multi-tenant networking. To
make it clear what turns on multi-tenant networking testing.
Change-Id: I6126dd385c6a341e18b825c00d4afe9194d32b35
Run ironic-dbsync online_data_migrations on single node grenade
right after usual dbsync.
Do not set pin_relase_version for single node grenade as we
do cold upgrade and it is not required.
Related-Bug: 1526283
Related-Bug: 1502887
Change-Id: I2e331252aeb66376c2d6cc3c16b6de0aefca5434