This issue will occurs when they validate with test-requirements in
constraints.
issue logs:
| ubuntu-xenial | Validating test-requirements.txt
| ubuntu-xenial | Requirement for package stestr has no lower bound
Change-Id: I61a25bc6ccbc97006443db8f9086bec41506e940
hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: I688a5f322bba52ae3b9fa5ecab5bed4f58fec542
Rather than pinning pycodestyle, ignore the E402 and W503 error. Fix
issue with E731 (Do not assign a lambda expression, use a def).
W503 is something we will likely never enable as it is a personal
style decision and can change depending on the code. There is no one
right answer. Interestingly there is also a W504 which is the opposite
check.
E402 is one we should most likely fix. But it can be done in a follow
patch or patches.
List of various error codes:
https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes
Change-Id: Ie2c31a8a3c75beeef22453cab5878cf0094bdf3f
- python-subunit is not used directly anywhere
and it is dependency of both testrepository and os-testr
(probably was used by some tox wrapper script before)
- python-ironicclient is not used anywhere
(probably should've been used by functional tests,
but we still have none of those).
Change-Id: I42aeb75dab18d90d60792f070599532fd3d9af10
Update test-requirements.txt to use latest versions of:
* flake8-import-order
* hacking
Enable the following off-by-default checks:
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
Fix code that failed H204 and H205. In this case the fix was to add:
# noqa
As we want to ensure that these particular tests are calling the
desired comparison operators.
Change-Id: If9cba62c832e301ac81320f9142e91319f0e40a9
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: I635dbf199bad59c72401a4de1de5200132746f6f
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: I821fd7467f6c5cc1487149297f26e4ad539cf25d
Use hacking 0.12.0
Use the new checks that are available:
[H106] Don’t put vim configuration in source files.
[H203] Use assertIs(Not)None to check for None.
[H904] Delay string interpolations at logging calls.
Fix code so tests pass.
Change-Id: I902e999687b066800e18fafd091571bf718b15f4
Depends-On: I2aa44b62f900d4dfd67701b01eadd0523fbfaf07
This installs the basic directories and content pointing to the current
Ironic Installation Guide. Simply having this in our repo will not lead
to it being published, this is only the first step. Having these items
in our repository is a good first step to building out our install
guide.
Change-Id: I6a0e69bd3b6f5074ae61505f82f27bcf9df84bab
Partial-bug: #1612278
Update the hacking test-requirement to match openstack/requirements
global-requirements.txt
Remove author lines from some files to fix error:
[H105] Don't use author tags. As we use version control instead
The hacking requirement is not updated by the proposal bot.
Change-Id: I8a35a7ebd811c477c893c7b5e854c46acc075af0