From bf318310e6534c6074d15229c20555b459e517dd Mon Sep 17 00:00:00 2001
From: Maksim Malchuk <maksim.malchuk@gmail.com>
Date: Tue, 23 Nov 2021 21:09:49 +0300
Subject: [PATCH] Fix 'ModuleNotFoundError: No module named 'docker'

In some cases, for example with custom inventory, we still have an
ordering issue and shouldn't rely only on 'docker.service' check.
We should use 'docker rm' shell command prior 'Docker SDK for Python'
is installed.

Change-Id: I90223a36ff3fc71585cb9302573154a5921041ff
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
---
 ansible/roles/ntp/tasks/prepare.yml | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/ansible/roles/ntp/tasks/prepare.yml b/ansible/roles/ntp/tasks/prepare.yml
index d625411cb..5e365165a 100644
--- a/ansible/roles/ntp/tasks/prepare.yml
+++ b/ansible/roles/ntp/tasks/prepare.yml
@@ -14,13 +14,21 @@
   with_items: "{{ ntp_service_disable_list }}"
 
 - name: Remove kolla-ansible installed chrony container
-  docker_container:
-    name: chrony
-    state: absent
+  shell:
+    cmd: >
+      if [[ -n $(docker ps -aq -f name=chrony) ]]; then
+        docker rm -f -v chrony
+      fi
+    executable: "/bin/bash"
+  register: result
+  changed_when: result.stdout != ""
   become: true
   # NOTE(wszumski):  There is an ordering issue where on a fresh host, docker
   # will not have been configured, but if that is the case, the chrony container
   # can't possibly exist, but trying to execute this unconditionally will fail
   # with: No module named 'docker' as we have not yet added the docker package
-  # to the kayobe target venv.
-  when: "'docker.service' in ansible_facts.services"
+  # to the kayobe target venv, so we use 'docker rm' command with force and
+  # don't fail on error.
+  when:
+    - "'docker.service' in ansible_facts.services"
+    - ansible_facts.services['docker.service'].status == 'running'