f639ad0b35
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.<fact>. This change updates all references to Ansible facts within Kayobe from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. This change disables fact variable injection in the ansible configuration used in CI, to catch any attempts to use the injected variables. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Story: 2007993 Task: 42464 Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/791276 Change-Id: I14db53ed6e57d37bbd28dd5819e432e3fe6628b2
27 lines
933 B
YAML
27 lines
933 B
YAML
---
|
|
- name: Populate service facts
|
|
service_facts:
|
|
|
|
- name: Mask alternative NTP clients to prevent conflicts
|
|
vars:
|
|
service_exists: "{{ item in ansible_facts.services }}"
|
|
systemd:
|
|
name: "{{ item }}"
|
|
enabled: "{{ 'false' if service_exists else omit }}"
|
|
masked: true
|
|
state: "{{ 'stopped' if service_exists else omit }}"
|
|
become: true
|
|
with_items: "{{ ntp_service_disable_list }}"
|
|
|
|
- name: Remove kolla-ansible installed chrony container
|
|
docker_container:
|
|
name: chrony
|
|
state: absent
|
|
become: true
|
|
# NOTE(wszumski): There is an ordering issue where on a fresh host, docker
|
|
# will not have been configured, but if that is the case, the chrony container
|
|
# can't possibly exist, but trying to execute this unconditionally will fail
|
|
# with: No module named 'docker' as we have not yet added the docker package
|
|
# to the kayobe target venv.
|
|
when: "'docker.service' in ansible_facts.services"
|