openstack/kolla-ansible
Code Issues Proposed changes
38ca1431d7
kolla-ansible/ansible/roles/gnocchi/tasks/external_ceph.yml

42 lines
1.1 KiB
YAML
Raw Normal View History

Integrate gnocchi with ceph Gnocchi previously lacked high availability. We consider a lack of HA in our a vast majority of operator oriented services to be a defective design choice. this change integrates gnocchi with ceph to resolve the the lack of HA. Closes-Bug: #1626623 Change-Id: I71c5137842cb48bc4af0e50a2952df5631d0d6df
2016-09-22 00:17:47 +08:00
---
- name: Copy over ceph.conf file
Handle external ceph configs as templates Change-Id: Ice5b058fe17ad7d648f21d1ddacaa339c6f7102f
2018-03-06 18:47:42 +01:00
template:
Fix copy external ceph files from custome/gnocchi in gnocchi There is no need to load custom ceph.conf and keyring from different folder for gnocchi components. Just load the files from node_custom_config/gnocchi folder. Depends-On: I379ff17856509c9321b86c13a72eacc18f5c1202 Change-Id: Id553dff274a29d82fb1b743437e3656d6f817e52
2018-06-11 11:21:53 +08:00
src: "{{ node_custom_config }}/gnocchi/ceph.conf"
Integrate gnocchi with ceph Gnocchi previously lacked high availability. We consider a lack of HA in our a vast majority of operator oriented services to be a defective design choice. this change integrates gnocchi with ceph to resolve the the lack of HA. Closes-Bug: #1626623 Change-Id: I71c5137842cb48bc4af0e50a2952df5631d0d6df
2016-09-22 00:17:47 +08:00
dest: "{{ node_config_directory }}/{{ item }}/ceph.conf"
Fix up config file permissions on the host Several config file permissions are incorrect on the host. In general, files should be 0660, and directories and executables 0770. Change-Id: Id276ac1864f280554e98b937f2845bb424d521de Closes-Bug: #1821579
2019-03-22 19:18:45 +00:00
mode: "0660"
Fix non-root reconfiguration with ceph enabled Various ceph-related tasks were missing a 'become' that would allow them to work as a non-root user. This seems to only cause a problem after an initial deployment, perhaps due to the recursive ownership & permissions changes at the end of the ceph.yml and external_ceph.yml files. This change adds the necessary becomes. Change-Id: I887c7b3bdef49db1dd1bf9e5bdbf5dc47b7f41af Closes-Bug: #1795125
2018-10-02 09:16:34 +01:00
become: true
Integrate gnocchi with ceph Gnocchi previously lacked high availability. We consider a lack of HA in our a vast majority of operator oriented services to be a defective design choice. this change integrates gnocchi with ceph to resolve the the lack of HA. Closes-Bug: #1626623 Change-Id: I71c5137842cb48bc4af0e50a2952df5631d0d6df
2016-09-22 00:17:47 +08:00
when: inventory_hostname in groups[item]
with_items:
- "gnocchi-api"
- "gnocchi-metricd"
- "gnocchi-statsd"
Restart services after a change in the external ceph configuration Change-Id: I6b6114e85a4df82458c441f471929513c2526c23
2017-09-27 17:01:21 +02:00
notify:
Simplify handler conditionals Currently, we have a lot of logic for checking if a handler should run, depending on whether config files have changed and whether the container configuration has changed. As rm_work pointed out during the recent haproxy refactor, these conditionals are typically unnecessary - we can rely on Ansible's handler notification system to only trigger handlers when they need to run. This removes a lot of error prone code. This patch removes conditional handler logic for all services. It is important to ensure that we no longer trigger handlers when unnecessary, because without these checks in place it will trigger a restart of the containers. Implements: blueprint simplify-handlers Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
2019-03-26 09:56:29 +00:00
- Restart {{ item }} container
Integrate gnocchi with ceph Gnocchi previously lacked high availability. We consider a lack of HA in our a vast majority of operator oriented services to be a defective design choice. this change integrates gnocchi with ceph to resolve the the lack of HA. Closes-Bug: #1626623 Change-Id: I71c5137842cb48bc4af0e50a2952df5631d0d6df
2016-09-22 00:17:47 +08:00
- name: Copy over ceph gnocchi keyring
copy:
External Ceph: keys as variables Introduce user modifiable variables instead of fixed-names of Ceph keyring files for external Ceph functionality. Change-Id: I1a33b3f9d6eca5babf53b91187461e43aef865ce
2019-09-26 12:41:18 +02:00
src: "{{ node_custom_config }}/gnocchi/{{ ceph_gnocchi_keyring }}"
dest: "{{ node_config_directory }}/{{ item }}/{{ ceph_gnocchi_keyring }}"
Fix up config file permissions on the host Several config file permissions are incorrect on the host. In general, files should be 0660, and directories and executables 0770. Change-Id: Id276ac1864f280554e98b937f2845bb424d521de Closes-Bug: #1821579
2019-03-22 19:18:45 +00:00
mode: "0660"
Fix non-root reconfiguration with ceph enabled Various ceph-related tasks were missing a 'become' that would allow them to work as a non-root user. This seems to only cause a problem after an initial deployment, perhaps due to the recursive ownership & permissions changes at the end of the ceph.yml and external_ceph.yml files. This change adds the necessary becomes. Change-Id: I887c7b3bdef49db1dd1bf9e5bdbf5dc47b7f41af Closes-Bug: #1795125
2018-10-02 09:16:34 +01:00
become: true
Integrate gnocchi with ceph Gnocchi previously lacked high availability. We consider a lack of HA in our a vast majority of operator oriented services to be a defective design choice. this change integrates gnocchi with ceph to resolve the the lack of HA. Closes-Bug: #1626623 Change-Id: I71c5137842cb48bc4af0e50a2952df5631d0d6df
2016-09-22 00:17:47 +08:00
when: inventory_hostname in groups[item]
with_items:
- "gnocchi-api"
- "gnocchi-metricd"
- "gnocchi-statsd"
Restart services after a change in the external ceph configuration Change-Id: I6b6114e85a4df82458c441f471929513c2526c23
2017-09-27 17:01:21 +02:00
notify:
Simplify handler conditionals Currently, we have a lot of logic for checking if a handler should run, depending on whether config files have changed and whether the container configuration has changed. As rm_work pointed out during the recent haproxy refactor, these conditionals are typically unnecessary - we can rely on Ansible's handler notification system to only trigger handlers when they need to run. This removes a lot of error prone code. This patch removes conditional handler logic for all services. It is important to ensure that we no longer trigger handlers when unnecessary, because without these checks in place it will trigger a restart of the containers. Implements: blueprint simplify-handlers Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
2019-03-26 09:56:29 +00:00
- Restart {{ item }} container
Add the missing permission setting for external-ceph when non-root (become), the permission changed is necessary, but some roles is missing, the patch to add it. Change-Id: I987becde489f4b509b32edc1deceabfa2d2e1b74
2018-01-22 17:11:19 +08:00
- name: Ensuring config directory has correct owner and permission
become: true
file:
path: "{{ node_config_directory }}/{{ item }}"
recurse: yes
owner: "{{ config_owner_user }}"
group: "{{ config_owner_group }}"
when: inventory_hostname in groups[item]
with_items:
- "gnocchi-api"
- "gnocchi-metricd"
- "gnocchi-statsd"
Copy Permalink