openstack/kolla-ansible
Code Issues Proposed changes

Drop the NTP service precheck

Browse Source 
We can't check this with timedatectl as it is not aware
of any "non-native" NTP daemon.

This could be a warning-level message but we don't have
such messages from the prechecks.

Closes-Bug: #1922721
Change-Id: I6db37576118cf5cff4ba7a63e179f0ab37467d22
This commit is contained in:
Radosław Piliszek 2021-04-06 12:19:47 +00:00
parent b647cb4128
commit 04315751a4
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ansible/roles/prechecks/tasks/timesync_checks.yml
View File

@ -5,16 +5,6 @@
register: timedatectl_status
changed_when: false
- name: Fail if no (S)NTP service is running
fail:
msg: >-
timedatectl does not see any (S)NTP service running.
Please ensure you have (S)NTP client working.
when:
- "'service: active' not in timedatectl_status.stdout"
# Ubuntu Bionic (18.04)
- "'service active: yes' not in timedatectl_status.stdout"
- name: Fail if the clock is not synchronized
fail:
msg: >-

7
releasenotes/notes/bug-1922721-19163cfb491d0035.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
Fixes an issue preventing prechecks from succeeding when "non-native"
NTP daemon was used, such as ``ntpd` as opposed to ``systemd-timesyncd``
on a Debian/Ubuntu system or to ``chronyd`` on a CentOS/RHEL system.
`LP#1922721 <https://launchpad.net/bugs/1922721>`__