From 8bf8656dbad3def707eca2d8ddd2c9bfed389b86 Mon Sep 17 00:00:00 2001
From: Bartosz Bezak <bartosz@stackhpc.com>
Date: Tue, 15 Nov 2022 11:08:15 +0100
Subject: [PATCH] Generate ovn-chassis-mac-mappings on ovn-controller group

Previously ovn-chassis-mac-mappings [1] has been added only to
ovn-controller-compute group. However external ports are being
scheduled on network nodes, therefore we need also do that there.

Closes-Bug: 1995078

[1] https://github.com/ovn-org/ovn/blob/v22.09.0/controller/ovn-controller.8.xml#L239

Change-Id: Ie62e9220bad56262cad602ca1480e6ca65827819
---
 ansible/roles/ovn/tasks/bootstrap.yml                | 2 +-
 releasenotes/notes/bug-1995078-2671a868c4fd27d3.yaml | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 releasenotes/notes/bug-1995078-2671a868c4fd27d3.yaml

diff --git a/ansible/roles/ovn/tasks/bootstrap.yml b/ansible/roles/ovn/tasks/bootstrap.yml
index 7c2fb0f14a..3e6065919e 100644
--- a/ansible/roles/ovn/tasks/bootstrap.yml
+++ b/ansible/roles/ovn/tasks/bootstrap.yml
@@ -34,6 +34,6 @@
     - { name: ovn-remote-probe-interval, value: "{{ ovn_remote_probe_interval }}" }
     - { name: ovn-openflow-probe-interval, value: "{{ ovn_openflow_probe_interval }}" }
     - { name: ovn-bridge-mappings, value: "{{ ovn_mappings }}", state: "{{ 'present' if (inventory_hostname in groups['ovn-controller-network'] or computes_need_external_bridge | bool) else 'absent' }}" }
-    - { name: ovn-chassis-mac-mappings, value: "{{ ovn_macs }}", state: "{{ 'present' if inventory_hostname in groups['ovn-controller-compute'] else 'absent' }}" }
+    - { name: ovn-chassis-mac-mappings, value: "{{ ovn_macs }}", state: "{{ 'present' if inventory_hostname in groups['ovn-controller'] else 'absent' }}" }
     - { name: ovn-cms-options, value: "{{ ovn_cms_opts }}", state: "{{ 'present' if ovn_cms_opts != '' else 'absent' }}" }
   when: inventory_hostname in groups.get('ovn-controller', [])
diff --git a/releasenotes/notes/bug-1995078-2671a868c4fd27d3.yaml b/releasenotes/notes/bug-1995078-2671a868c4fd27d3.yaml
new file mode 100644
index 0000000000..e0955dfe80
--- /dev/null
+++ b/releasenotes/notes/bug-1995078-2671a868c4fd27d3.yaml
@@ -0,0 +1,9 @@
+---
+fixes:
+  - |
+    Fixes ``ovn-chassis-mac-mappings`` missing on network nodes.
+    Previously ``ovn-chassis-mac-mappings`` has been added only to
+    ``ovn-controller-compute`` group. However external ports are being
+    scheduled on network nodes. Adding ``ovn-chassis-mac-mappings``
+    on whole ``ovn-controller`` group fixes the bug.
+    `LP#1995078 <https://launchpad.net/bugs/1995078>`__