From 2455a95f3464660001a6e341f8d9d2a92310a002 Mon Sep 17 00:00:00 2001 From: Michal Arbet Date: Mon, 11 Oct 2021 12:01:18 +0200 Subject: [PATCH] Trivial but necessary fix - loadbalancer weight Weight for haproxy backend was merged in [1] with tiny bug, there is need to convert to int to check conditional <= 256. Otherwise, it's not working as expected. [1] https://review.opendev.org/c/openstack/kolla-ansible/+/775627 Change-Id: Icb6f5147ebd2a0be52ba4ef6ba4a00bbd0242d3d --- .../templates/haproxy_single_service_split.cfg.j2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible/roles/haproxy-config/templates/haproxy_single_service_split.cfg.j2 b/ansible/roles/haproxy-config/templates/haproxy_single_service_split.cfg.j2 index f2f57cd0d8..7dfbcc012e 100644 --- a/ansible/roles/haproxy-config/templates/haproxy_single_service_split.cfg.j2 +++ b/ansible/roles/haproxy-config/templates/haproxy_single_service_split.cfg.j2 @@ -95,7 +95,7 @@ backend {{ service_name }}_back {% set host_ip = 'api' | kolla_address(host) %} {% set service_weight = 'haproxy_' + service_name + '_weight' %} {% set backend_weight_info = '' %} - {% if hostvars[host][service_weight] is defined and hostvars[host][service_weight] | int != 0 and hostvars[host][service_weight] <= 256 %} + {% if hostvars[host][service_weight] is defined and hostvars[host][service_weight] | int != 0 and hostvars[host][service_weight] | int <= 256 %} {% set backend_weight_info = 'weight %s'|format(hostvars[host][service_weight]) %} {% endif %} server {{ host_name }} {{ host_ip }}:{{ listen_port }} {{ haproxy_health_check_final }} {{ backend_tls_info }} {{ backend_weight_info }}