From b854308328fd3d828e3a6955a7155db3b67bca42 Mon Sep 17 00:00:00 2001 From: Chulmin Kang Date: Sat, 13 Oct 2018 03:10:50 +0900 Subject: [PATCH] Fix on setting enable_openvswitch In the default expression which sets enable_openvswitch, the boolean filter is applied only on 'linuxbridge', not on the whole comparing expression. So even if neutron_plugin_agent is set to 'linuxbridge', but enable_openvswitch is not explicitly set to "no" (e.g., in globals.yml), then enable_openvswitch is eventually set to true, and openvswitch role is unintentionally applied. Boolean filter is not really necessary on the comparing expression, so it can be removed just like in globals.yml. Change-Id: I0612346484eada8192ee03dc9d5057cb6881f532 Closes-bug: #1747136 --- ansible/group_vars/all.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible/group_vars/all.yml b/ansible/group_vars/all.yml index 8a438ce030..f4835cde79 100644 --- a/ansible/group_vars/all.yml +++ b/ansible/group_vars/all.yml @@ -514,7 +514,7 @@ enable_nova_ssh: "yes" enable_octavia: "no" enable_onos: "no" enable_opendaylight: "no" -enable_openvswitch: "{{ neutron_plugin_agent != 'linuxbridge' | bool }}" +enable_openvswitch: "{{ neutron_plugin_agent != 'linuxbridge' }}" enable_ovs_dpdk: "no" enable_osprofiler: "no" enable_panko: "no"