openstack/kolla-ansible
Code Issues Proposed changes

Don't allocate pseudo-TTY when creating containers

Browse Source 
With a pseudo terminal, service is not treated as a daemon
and signals would not work as expected.

Change-Id: I16aa29a7924df51659d973a81d8005ae3d86f57b
Related-Bug: #1799642
This commit is contained in:
Rabi Mishra 2018-10-31 16:42:52 +05:30
parent 1731f81fa0
commit 48bae90e8f
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ansible/library/kolla_docker.py
View File

@ -639,7 +639,6 @@ class DockerWorker(object):
'image': self.params.get('image'), 'image': self.params.get('image'),
'name': self.params.get('name'), 'name': self.params.get('name'),
'volumes': volumes, 'volumes': volumes,
'tty': True
} }
def create_container(self): def create_container(self):

1
tests/test_kolla_docker.py
View File

@ -133,7 +133,6 @@ FAKE_DATA = {
'image': 'myregistrydomain.com:5000/ubuntu:16.04', 'image': 'myregistrydomain.com:5000/ubuntu:16.04',
'name': 'test_container', 'name': 'test_container',
'volumes': None, 'volumes': None,
'tty': True
}, },
'images': [ 'images': [