openstack/kolla-ansible
Code Issues Proposed changes

Remove notifiers from loadbalancer config

Browse Source 
No handlers should be triggered during config. Container
will be restarted automatically when check-containers
is ran for the loadbalancer containers if config
has changed.

Change-Id: I05b587364ad174d8944c95e54e6e6853d34ec83c
Signed-off-by: Roman Krček <roman.krcek@tietoevry.com>
This commit is contained in:
Roman Krček
2025-04-03 07:50:22 +00:00
parent fab49f3307
commit 64cd8e007c
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ansible/roles/haproxy-config/tasks/main.yml
View File

@@ -19,8 +19,6 @@
- service.haproxy is defined - service.haproxy is defined
- enable_haproxy | bool - enable_haproxy | bool
with_dict: "{{ project_services }}" with_dict: "{{ project_services }}"
notify:
- Restart haproxy container
- name: "Add configuration for {{ project_name }} when using single external frontend" - name: "Add configuration for {{ project_name }} when using single external frontend"
vars: vars:
@@ -49,8 +47,6 @@
- service.enabled | bool - service.enabled | bool
- service.haproxy is defined - service.haproxy is defined
- enable_haproxy | bool - enable_haproxy | bool
notify:
- Restart haproxy container
- name: "Configuring firewall for {{ project_name }}" - name: "Configuring firewall for {{ project_name }}"
firewalld: firewalld:

4
ansible/roles/proxysql-config/tasks/main.yml
View File

@@ -7,8 +7,6 @@
become: true become: true
when: when:
- proxysql_config_users | bool - proxysql_config_users | bool
notify:
- Restart proxysql container
- name: "Copying over {{ proxysql_project }} ProxySQL rules config" - name: "Copying over {{ proxysql_project }} ProxySQL rules config"
template: template:
@@ -18,5 +16,3 @@
become: true become: true
when: when:
- proxysql_config_rules | bool - proxysql_config_rules | bool
notify:
- Restart proxysql container

6
ansible/site.yml
View File

@@ -315,6 +315,12 @@
tasks_from: loadbalancer tasks_from: loadbalancer
tags: zun tags: zun
when: enable_zun | bool when: enable_zun | bool
# NOTE(r-krcek): This last step will notify handlers if any
# changes to the configuration have been made.
- include_role:
name: loadbalancer
tasks_from: check-containers
when: kolla_action != 'config'
when: when:
- enable_haproxy | bool - enable_haproxy | bool
- kolla_action in ['deploy', 'reconfigure', 'upgrade', 'config'] - kolla_action in ['deploy', 'reconfigure', 'upgrade', 'config']