openstack/kolla-ansible
Code Issues Proposed changes

Default to disabling haproxy for memcached

Browse Source 
Since at least the Rocky release we have been enabling
this needlessly.
The enable_haproxy_memcached parameter is not documented but it
can be kept as it is very light on maintenance.

Change-Id: I8b3a6a9f676d2d79657d859190198b17cc8e8a82
This commit is contained in:
Radosław Piliszek 2019-10-24 09:09:45 +02:00
parent d40bdf4005
commit 668463ef19
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ansible/group_vars/all.yml
View File

@ -541,11 +541,10 @@ enable_nova: "{{ enable_openstack_core | bool }}"
enable_rabbitmq: "{{ 'yes' if om_rpc_transport == 'rabbit' or om_notify_transport == 'rabbit' else 'no' }}" enable_rabbitmq: "{{ 'yes' if om_rpc_transport == 'rabbit' or om_notify_transport == 'rabbit' else 'no' }}"
enable_outward_rabbitmq: "{{ enable_murano | bool }}" enable_outward_rabbitmq: "{{ enable_murano | bool }}"
# Most memcache clients handle load-balancing via client side # NOTE: Most memcached clients handle load-balancing via client side
# hashing (consistent or not) logic, so going under the covers and messing # hashing (consistent or not) logic, so going under the covers and messing
# with things that the clients are not aware of is general wrong (but this # with things that the clients are not aware of is generally wrong
# keeps the default as is...) enable_haproxy_memcached: "no"
enable_haproxy_memcached: "yes"
# Additional optional OpenStack features and services are specified here # Additional optional OpenStack features and services are specified here
enable_aodh: "no" enable_aodh: "no"

7
releasenotes/notes/do-not-haproxy-memcached-by-default-4676a56524922c8f.yaml Normal file
View File

@ -0,0 +1,7 @@
---
upgrade:
- |
Changes default value of ``enable_haproxy_memcached`` to ``no``.
Memcached has not been accessed via haproxy since at least
the Rocky release. Users depending on haproxy for memcached
for other software may want to change this back to ``yes``.